Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PowerPC wheels for LQ #902

Merged
merged 4 commits into from
Sep 10, 2024
Merged

Remove PowerPC wheels for LQ #902

merged 4 commits into from
Sep 10, 2024

Conversation

maliasadi
Copy link
Member

@maliasadi maliasadi commented Sep 9, 2024

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    tests directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the .github/CHANGELOG.md file, summarizing the
    change, and including a link back to the PR.

  • Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context:
Remove PowerPC wheel recipe for Lightning-Qubit. Users can still install LQ from source by following the installation guideline:

pip install pennylane-lightning --no-binary :all:

Description of the Change:

  • Remove .github/workflows/wheel_linux_ppc64le.yml
  • Update README

Benefits:
Reduce the number of wheels recipes and CI checks per PR. We can revert this if it turns out that many rely on these wheels.

Possible Drawbacks:
PowerPC wheels will not be built and uploaded to PyPI and TestPyPI starting with v0.39.0

Related GitHub Issues:
[sc-73503]

@maliasadi maliasadi requested review from mlxd and a team September 9, 2024 20:27
Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.06%. Comparing base (75dfecb) to head (1ffbc13).
Report is 75 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (75dfecb) and HEAD (1ffbc13). Click for more details.

HEAD has 34 uploads less than BASE
Flag BASE (75dfecb) HEAD (1ffbc13)
40 6
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #902       +/-   ##
===========================================
- Coverage   97.67%   59.06%   -38.62%     
===========================================
  Files         212       24      -188     
  Lines       29084     2162    -26922     
===========================================
- Hits        28408     1277    -27131     
- Misses        676      885      +209     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@vincentmr vincentmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @maliasadi .

Copy link
Member

@mlxd mlxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So long, PPC64LE.

Copy link
Contributor

@AmintorDusko AmintorDusko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@maliasadi maliasadi merged commit cc36544 into master Sep 10, 2024
67 of 76 checks passed
@maliasadi maliasadi deleted the rm_ppc branch September 10, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants