Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print error on import #866

Closed
wants to merge 3 commits into from
Closed

Print error on import #866

wants to merge 3 commits into from

Conversation

mlxd
Copy link
Member

@mlxd mlxd commented Aug 23, 2024

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    tests directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the .github/CHANGELOG.md file, summarizing the
    change, and including a link back to the PR.

  • Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context:

Description of the Change:

Benefits:

Possible Drawbacks:

Related GitHub Issues:

@mlxd mlxd added the ci:build_wheels Activate wheel building. label Aug 23, 2024
@mlxd mlxd marked this pull request as ready for review August 23, 2024 20:06
Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit .github/CHANGELOG.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

Copy link

codecov bot commented Aug 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.34%. Comparing base (dd5dca1) to head (b5d8b20).

❗ There is a different number of reports uploaded between BASE (dd5dca1) and HEAD (b5d8b20). Click for more details.

HEAD has 7 uploads less than BASE
Flag BASE (dd5dca1) HEAD (b5d8b20)
12 5
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #866       +/-   ##
===========================================
- Coverage   97.59%   27.34%   -70.25%     
===========================================
  Files         117       17      -100     
  Lines       18642     1993    -16649     
===========================================
- Hits        18193      545    -17648     
- Misses        449     1448      +999     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mlxd
Copy link
Member Author

mlxd commented Sep 10, 2024

Closing in favour of updates in #901

@mlxd mlxd closed this Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:build_wheels Activate wheel building.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants