Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the long_description issues in Lightning #858

Merged
merged 4 commits into from
Aug 19, 2024

Conversation

maliasadi
Copy link
Member

@maliasadi maliasadi commented Aug 19, 2024

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    tests directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the .github/CHANGELOG.md file, summarizing the
    change, and including a link back to the PR.

  • Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context:
Lightning wheels are currently failing when checking the wheels with twine. This PR fixes all the rendering issues in the README.

Description of the Change:

Benefits:

Possible Drawbacks:

Related GitHub Issues:
[sc-71706]

Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit .github/CHANGELOG.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@maliasadi maliasadi added the ci:build_wheels Activate wheel building. label Aug 19, 2024
Copy link
Member

@multiphaseCFD multiphaseCFD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks @maliasadi !

Copy link

codecov bot commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.57%. Comparing base (9618fd5) to head (e951ba0).
Report is 83 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #858       +/-   ##
===========================================
- Coverage   91.59%   81.57%   -10.03%     
===========================================
  Files          85       17       -68     
  Lines       10952     1916     -9036     
===========================================
- Hits        10032     1563     -8469     
+ Misses        920      353      -567     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@vincentmr vincentmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @maliasadi .

@maliasadi maliasadi merged commit 6b42030 into master Aug 19, 2024
98 of 99 checks passed
@maliasadi maliasadi deleted the fix_wheels_twine_check branch August 19, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:build_wheels Activate wheel building.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants