-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add (check) full support for sampling in full parity with Lightning #836
Conversation
Co-authored-by: Vincent Michaud-Rioux <[email protected]>
Co-authored-by: Vincent Michaud-Rioux <[email protected]>
Co-authored-by: Ali Asadi <[email protected]>
Co-authored-by: Ali Asadi <[email protected]>
Co-authored-by: Ali Asadi <[email protected]>
Co-authored-by: Ali Asadi <[email protected]>
Co-authored-by: Ali Asadi <[email protected]>
Co-authored-by: Ali Asadi <[email protected]>
Co-authored-by: Vincent Michaud-Rioux <[email protected]>
Co-authored-by: Vincent Michaud-Rioux <[email protected]>
Hello. You may have forgotten to update the changelog!
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## kokkosNewAPI_backend #836 +/- ##
=======================================================
Coverage ? 87.11%
=======================================================
Files ? 20
Lines ? 2274
Branches ? 0
=======================================================
Hits ? 1981
Misses ? 293
Partials ? 0 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First round of review incoming! Cheers @LuisAlfredoNu .
Co-authored-by: Vincent Michaud-Rioux <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks @LuisAlfredoNu! I'll review tests when reviewing the base branch.
Co-authored-by: Ali Asadi <[email protected]>
Co-authored-by: Ali Asadi <[email protected]>
Co-authored-by: Vincent Michaud-Rioux <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
# As ControlledQubitUnitary == C(QubitUnitrary), | ||
# it can be removed from `_operations` to keep | ||
# consistency with `lightning_qubit.toml` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to keep this comment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think now it is not necessary. I will delete it 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, cheers @LuisAlfredoNu .
Co-authored-by: Amintor Dusko <[email protected]>
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
tests
directory!All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs
.Ensure that the test suite passes, by running
make test
.Add a new entry to the
.github/CHANGELOG.md
file, summarizing thechange, and including a link back to the PR.
Ensure that code is properly formatted by running
make format
.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context:
Migrate the lightning.kokkos device to the new device API.
Description of the Change:
Add the necessary method for the LightningKokkos that allows the use of new device API. It should have a similar structure as the LightningQubit class.
Note: Lightning Kokkos does not support MCMC sampling.
Benefits:
Integration of LighntingKokkos with the new device API.
Possible Drawbacks:
Related GitHub Issues:
Partial / Freezzed PR⚠️ ❄️
To make a smooth integration of LightningKokkos with the new device API, we set the branch
kokkosNewAPI_backend
as the base branch target for this development.The branch
kokkosNewAPI_backend
has the mock of all classes and methods necessary for the new API. Also, several tests were disabled withAdditionally, the CI testing from PennyLane for LKokkos is temporally disabled through commenting on the following lines in .github/workflows files
However, these tests will unblocked as the implementation progresses.
After all the developments for integrating LightningKokkos with the new API have been completed then the PR will be open to merging to master
[sc-68820]