Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding semantic-version to workflow reqs #835

Merged
merged 2 commits into from
Aug 2, 2024

Conversation

PietropaoloFrisoni
Copy link
Contributor

@PietropaoloFrisoni PietropaoloFrisoni commented Aug 2, 2024

This PR should fix this test in the plugin-test-matrix. The latest PL version does not use semantic-version, but the stable version still does, so we add such a package to the workflow requirements.

Copy link
Contributor

github-actions bot commented Aug 2, 2024

Hello. You may have forgotten to update the changelog!
Please edit .github/CHANGELOG.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

Copy link

codecov bot commented Aug 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.30%. Comparing base (186a1b1) to head (b0cf9f8).
Report is 86 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (186a1b1) and HEAD (b0cf9f8). Click for more details.

HEAD has 64 uploads less than BASE
Flag BASE (186a1b1) HEAD (b0cf9f8)
69 5
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #835       +/-   ##
===========================================
- Coverage   98.52%   59.30%   -39.22%     
===========================================
  Files         114       17       -97     
  Lines       18147     1902    -16245     
===========================================
- Hits        17879     1128    -16751     
- Misses        268      774      +506     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PietropaoloFrisoni PietropaoloFrisoni changed the title Adding semantic-version to dependencies Adding semantic-version to workflow reqs Aug 2, 2024
Copy link
Contributor

@AmintorDusko AmintorDusko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the update!

@AmintorDusko AmintorDusko requested a review from a team August 2, 2024 12:06
@PietropaoloFrisoni PietropaoloFrisoni merged commit afb03e4 into master Aug 2, 2024
51 of 52 checks passed
@PietropaoloFrisoni PietropaoloFrisoni deleted the semantic_version_dep branch August 2, 2024 13:02
multiphaseCFD pushed a commit that referenced this pull request Aug 5, 2024
This PR should fix [this
test](https://github.com/PennyLaneAI/pennylane-lightning/actions/runs/10208461253/job/28245011292)
in the plugin-test-matrix. The latest PL version does not use
`semantic-version`, but the stable version still does, so we add such a
package to the workflow requirements.

---------

Co-authored-by: ringo-but-quantum <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants