-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix install paths for cuquantum in CI and docs #831
Conversation
Hello. You may have forgotten to update the changelog!
|
Fixes current MPI-build block in #823 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## fix_lgpu_aarch64 #831 +/- ##
====================================================
+ Coverage 98.52% 99.12% +0.60%
====================================================
Files 114 99 -15
Lines 18147 13243 -4904
====================================================
- Hits 17879 13127 -4752
+ Misses 268 116 -152 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mlxd ! Looks good to me! Does it mean that there will be a scenario that custatevec.so
located in /lib64/ dir?
No guarantee, but hard to know based on previous lib dirs I've seen in the wild. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've never run into this issue before. nice catch! 🏉
Co-authored-by: Ali Asadi <[email protected]>
Co-authored-by: Ali Asadi <[email protected]>
Co-authored-by: Ali Asadi <[email protected]>
Co-authored-by: Ali Asadi <[email protected]>
Co-authored-by: Ali Asadi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, feel free to merge when the CI is green. Cheers and thanks @mlxd !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🏉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thanks @mlxd !
FYI, as this flows into #823 I'm ignoring formatting checks until post-merge |
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
tests
directory!All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs
.Ensure that the test suite passes, by running
make test
.Add a new entry to the
.github/CHANGELOG.md
file, summarizing thechange, and including a link back to the PR.
Ensure that code is properly formatted by running
make format
.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context: Current install directions for cuquantum allow use of the RPATH to the expected directory with Python, but requires explicit targets when using a C++ build. The docs and paths searched for cuquantum right now often have the
lib
dir implicit in the path, which causes an incorrect path to be found by CMake, as it is a child class of the root. This PR fixes those such paths, allowing the C++ builds to find the correct custatevec libraries, ensuring a successful cmake configuration step.Description of the Change: As above.
Benefits:
Possible Drawbacks:
Related GitHub Issues: