Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix install paths for cuquantum in CI and docs #831

Merged
merged 9 commits into from
Aug 2, 2024

Conversation

mlxd
Copy link
Member

@mlxd mlxd commented Jul 31, 2024

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    tests directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the .github/CHANGELOG.md file, summarizing the
    change, and including a link back to the PR.

  • Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context: Current install directions for cuquantum allow use of the RPATH to the expected directory with Python, but requires explicit targets when using a C++ build. The docs and paths searched for cuquantum right now often have the lib dir implicit in the path, which causes an incorrect path to be found by CMake, as it is a child class of the root. This PR fixes those such paths, allowing the C++ builds to find the correct custatevec libraries, ensuring a successful cmake configuration step.

Description of the Change: As above.

Benefits:

Possible Drawbacks:

Related GitHub Issues:

@mlxd mlxd added bug-fix Indicates this fixes a known bug ci:use-multi-gpu-runner Enable usage of Multi-GPU runner for this Pull Request labels Jul 31, 2024
Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit .github/CHANGELOG.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@mlxd mlxd marked this pull request as ready for review July 31, 2024 14:38
@mlxd mlxd requested review from multiphaseCFD and maliasadi July 31, 2024 14:38
@mlxd
Copy link
Member Author

mlxd commented Jul 31, 2024

Fixes current MPI-build block in #823

Copy link

codecov bot commented Jul 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.12%. Comparing base (186a1b1) to head (e5994a9).

Additional details and impacted files
@@                 Coverage Diff                  @@
##           fix_lgpu_aarch64     #831      +/-   ##
====================================================
+ Coverage             98.52%   99.12%   +0.60%     
====================================================
  Files                   114       99      -15     
  Lines                 18147    13243    -4904     
====================================================
- Hits                  17879    13127    -4752     
+ Misses                  268      116     -152     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mlxd mlxd changed the base branch from master to fix_lgpu_aarch64 July 31, 2024 14:44
Copy link
Member

@multiphaseCFD multiphaseCFD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mlxd ! Looks good to me! Does it mean that there will be a scenario that custatevec.so located in /lib64/ dir?

@mlxd
Copy link
Member Author

mlxd commented Jul 31, 2024

Thanks @mlxd ! Looks good to me! Does it mean that there will be a scenario that custatevec.so located in /lib64/ dir?

No guarantee, but hard to know based on previous lib dirs I've seen in the wild.

@mlxd mlxd requested a review from vincentmr July 31, 2024 20:49
Copy link
Member

@maliasadi maliasadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've never run into this issue before. nice catch! 🏉

mlxd and others added 5 commits August 2, 2024 15:30
Copy link
Contributor

@vincentmr vincentmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, feel free to merge when the CI is green. Cheers and thanks @mlxd !

Copy link
Member

@maliasadi maliasadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏉

Copy link
Member

@multiphaseCFD multiphaseCFD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks @mlxd !

@mlxd
Copy link
Member Author

mlxd commented Aug 2, 2024

FYI, as this flows into #823 I'm ignoring formatting checks until post-merge

@mlxd mlxd merged commit 25348be into fix_lgpu_aarch64 Aug 2, 2024
75 of 77 checks passed
@mlxd mlxd deleted the fix_cusv_paths branch August 2, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix Indicates this fixes a known bug ci:use-multi-gpu-runner Enable usage of Multi-GPU runner for this Pull Request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants