Add `qml.state()` support to `lightning.tensor` #827

multiphaseCFD · 2024-07-30T20:09:02Z

Before submitting

Please complete the following checklist when submitting a PR:

All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
tests directory!
All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running make docs.
Ensure that the test suite passes, by running make test.
Add a new entry to the .github/CHANGELOG.md file, summarizing the
change, and including a link back to the PR.
Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.

Context:

[SC-70248]

Description of the Change:

Benefits:

Possible Drawbacks:

Related GitHub Issues:

### Before submitting Please complete the following checklist when submitting a PR: - [ ] All new features must include a unit test. If you've fixed a bug or added code that should be tested, add a test to the [`tests`](../tests) directory! - [ ] All new functions and code must be clearly commented and documented. If you do make documentation changes, make sure that the docs build and render correctly by running `make docs`. - [ ] Ensure that the test suite passes, by running `make test`. - [x] Add a new entry to the `.github/CHANGELOG.md` file, summarizing the change, and including a link back to the PR. - [x] Ensure that code is properly formatted by running `make format`. When all the above are checked, delete everything above the dashed line and fill in the pull request template. ------------------------------------------------------------------------------------------------------------ **Context:** Add GPU device compute capability check. L-Tensor has device compute capability check like L-GPU now. [SC-69118] **Description of the Change:** **Benefits:** Error will be raised when running `lightning.tensor` on a unsupported GPU. **Possible Drawbacks:** **Related GitHub Issues:** #799 --------- Co-authored-by: ringo-but-quantum <[email protected]>

vincentmr

Thanks @multiphaseCFD . LGTM, but I would tend to request adding a getDataVector function such as to reduce boilerplate in the unit tests (which could itself call getData though). I think we need both. What was the rationale for removing it?

pennylane_lightning/core/src/simulators/lightning_tensor/tncuda/MPSTNCuda.hpp

...ane_lightning/core/src/simulators/lightning_tensor/tncuda/bindings/LTensorTNCudaBindings.hpp

...ightning/core/src/simulators/lightning_tensor/tncuda/gates/tests/Test_MPSTNCuda_NonParam.cpp

pennylane_lightning/core/src/simulators/lightning_tensor/tncuda/tests/Tests_MPSTNCuda.cpp

pennylane_lightning/lightning_tensor/_tensornet.py

multiphaseCFD · 2024-08-12T13:17:51Z

Thanks @multiphaseCFD . LGTM, but I would tend to request adding a getDataVector function such as to reduce boilerplate in the unit tests (which could itself call getData though). I think we need both. What was the rationale for removing it?

Thanks @vincentmr ! The main reason is more product oriented. getData() will let our user to ensure that there is sufficient amount of host memory to store the state. It's the same logic of cutensornet, users have to be responsible for allocating sufficient amount of memory. Changes were made in lightning.tensor since the lack of host memory issue could be more prominent for the 100+ qubit MPS or Exact TN simulations. Will keep getDataVector().

vincentmr

LGTM, nice work @multiphaseCFD .

maliasadi

Nice work @multiphaseCFD! LGTM if you accept the suggestions before merge :)

pennylane_lightning/core/src/simulators/lightning_tensor/tncuda/TNCudaBase.hpp

tests/test_comparison.py

tests/test_templates.py

…a/TNCudaBase.hpp Co-authored-by: Ali Asadi <[email protected]>

Co-authored-by: Ali Asadi <[email protected]>

Please complete the following checklist when submitting a PR: - [x] All new features must include a unit test. If you've fixed a bug or added code that should be tested, add a test to the [`tests`](../tests) directory! - [ ] All new functions and code must be clearly commented and documented. If you do make documentation changes, make sure that the docs build and render correctly by running `make docs`. - [ ] Ensure that the test suite passes, by running `make test`. - [x] Add a new entry to the `.github/CHANGELOG.md` file, summarizing the change, and including a link back to the PR. - [x] Ensure that code is properly formatted by running `make format`. When all the above are checked, delete everything above the dashed line and fill in the pull request template. ------------------------------------------------------------------------------------------------------------ **Context:** [SC-70248] **Description of the Change:** **Benefits:** **Possible Drawbacks:** **Related GitHub Issues:** --------- Co-authored-by: ringo-but-quantum <[email protected]> Co-authored-by: Lee James O'Riordan <[email protected]> Co-authored-by: Lee J. O'Riordan <[email protected]> Co-authored-by: Ali Asadi <[email protected]>

multiphaseCFD and others added 30 commits July 16, 2024 20:36

init commit

9a0604a

make format

a3059ff

add unit tests for HermitianObs

9e83c44

initial commit

a929928

Merge branch 'master' into add_var_tensornet

1490267

Auto update version from '0.38.0-dev9' to '0.38.0-dev10'

3af11ac

make format

425126b

Auto update version from '0.38.0-dev10' to '0.38.0-dev11'

6da1e25

Merge branch 'master' into add_var_tensornet

9046199

Auto update version from '0.38.0-dev11' to '0.38.0-dev12'

3877ebf

make format

1b12733

add more complex Hermitian matrix

afa67c9

add python and pybind layer

49e529f

add more py unit tests

e97107e

add more unit tests

85a9bd5

add changelog

93ff20f

tidy up C++

fa2c8fb

further clean C++ layer

0cdc3d0

switch on more python unit tests

fca24d3

tidy up python layer

19dbedc

tidy up linaralg and add more unit tests

2737df1

Add var support to multi-terms Hamiltionian

976da4d

tidy up code

ad8d9bd

Auto update version from '0.38.0-dev12' to '0.38.0-dev13'

3ac6211

remove square_matrix_cuda_device

255e341

further tidy up

7b44e8a

fix typo

00beafa

initial commit

48f74b5

Merge branch 'master' into add_var_tensornet

cdb4606

multiphaseCFD added 3 commits August 9, 2024 15:56

add more unit tests for 0,1 qubit circuit

a84a5c8

update docstring

377b6de

add more py unit tests and avoid data copy in the pybind layer

4938835

multiphaseCFD requested review from vincentmr and maliasadi August 9, 2024 16:27

multiphaseCFD and others added 6 commits August 9, 2024 17:00

remove cudaStreamSync

4ab9999

decprecate getDataVector()

e95456b

update changelog entry

cb82ca5

add more C+ layer tests

6477f0c

Merge branch 'master' into add_accessor_ltensor

48d60d9

Auto update version from '0.38.0-dev28' to '0.38.0-dev29'

733b97a

vincentmr reviewed Aug 12, 2024

View reviewed changes

revert getDataVector deprecation

11de2cf

multiphaseCFD requested a review from vincentmr August 12, 2024 14:44

vincentmr approved these changes Aug 12, 2024

View reviewed changes

maliasadi approved these changes Aug 12, 2024

View reviewed changes

multiphaseCFD and others added 10 commits August 12, 2024 13:29

Update pennylane_lightning/core/src/simulators/lightning_tensor/tncud…

8324011

…a/TNCudaBase.hpp Co-authored-by: Ali Asadi <[email protected]>

Update pennylane_lightning/core/src/simulators/lightning_tensor/tncud…

53cad08

…a/TNCudaBase.hpp Co-authored-by: Ali Asadi <[email protected]>

Update pennylane_lightning/core/src/simulators/lightning_tensor/tncud…

2d0b7ee

…a/TNCudaBase.hpp Co-authored-by: Ali Asadi <[email protected]>

Update tests/test_comparison.py

984f100

Co-authored-by: Ali Asadi <[email protected]>

Update tests/test_comparison.py

49eca26

Co-authored-by: Ali Asadi <[email protected]>

Update tests/test_comparison.py

430971c

Co-authored-by: Ali Asadi <[email protected]>

Update tests/test_comparison.py

8fd4d1b

Co-authored-by: Ali Asadi <[email protected]>

update based on comments

53e3e5a

Merge branch 'master' into add_accessor_ltensor

3e8aaa0

Auto update version from '0.38.0-dev30' to '0.38.0-dev31'

ea4f5ea

multiphaseCFD merged commit 09d626b into master Aug 13, 2024
86 of 87 checks passed

multiphaseCFD deleted the add_accessor_ltensor branch August 13, 2024 12:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add `qml.state()` support to `lightning.tensor` #827

Add `qml.state()` support to `lightning.tensor` #827

multiphaseCFD commented Jul 30, 2024 •

edited

Loading

vincentmr left a comment

multiphaseCFD commented Aug 12, 2024 •

edited

Loading

vincentmr left a comment

maliasadi left a comment

Add qml.state() support to lightning.tensor #827

Add qml.state() support to lightning.tensor #827

Conversation

multiphaseCFD commented Jul 30, 2024 • edited Loading

Before submitting

vincentmr left a comment

Choose a reason for hiding this comment

multiphaseCFD commented Aug 12, 2024 • edited Loading

vincentmr left a comment

Choose a reason for hiding this comment

maliasadi left a comment

Choose a reason for hiding this comment

Add `qml.state()` support to `lightning.tensor` #827

Add `qml.state()` support to `lightning.tensor` #827

multiphaseCFD commented Jul 30, 2024 •

edited

Loading

multiphaseCFD commented Aug 12, 2024 •

edited

Loading