TOML files update #826
Merged
TOML files update #826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello. You may have forgotten to update the changelog!
|
|
@dime10 , please let me know if you want a different flag name. I think this is appropriate. |
maliasadi
reviewed
Jul 30, 2024
Co-authored-by: Ali Asadi <[email protected]>
|
Hey @erick-xanadu, could you please update your branch? (merge master) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #826 +/- ##
===========================================
- Coverage 96.94% 86.52% -10.43%
===========================================
Files 113 17 -96
Lines 18012 1914 -16098
===========================================
- Hits 17462 1656 -15806
+ Misses 550 258 -292 ☔ View full report in Codecov by Sentry. |
vincentmr
suggested changes
Aug 2, 2024
|
@vincentmr , done! |
vincentmr
approved these changes
Aug 2, 2024
multiphaseCFD
added a commit
that referenced
this pull request
Aug 2, 2024
This reverts commit cfc3006.
multiphaseCFD
pushed a commit
that referenced
this pull request
Aug 5, 2024
**Context:** We would like Catalyst to optimize the first instance of `qml.StatePrep` by just setting the state vector in PennyLane lightning. **Description of the Change:** To achieve this, we set a flag in the TOML files where it denotes whether the value for the flag `skip_initial_state_prep` used during decomposition. This flag is already in PennyLane and will skip the initial state preparation. There are other ways to achieve this but this is the least invasive way to do so. Some other alternatives that were discussed: 1. Adding StatePrep to the list of supported operations: this is not a good idea as it would lead StatePrep to not be decomposed ever. 2. Creating a new operation and map StatePrep directly into this new operation only in the context of Catalyst. This would lead to setting this new `qml` Operation in the list of supported operations on the device, even though it would never be seen except when using with Catalyst. The way this was achieved was not to create a new `qml` Operation, only an JAXPR/MLIR operation and bind `StatePrep` to this JAXPR operation and lower it through MLIR. So, no new `qml` operations. **Benefits:** Optimization **Possible Drawbacks:** More flags. No one likes flags. **Related GitHub Issues:** Will be followed by this PennyLaneAI/catalyst#955 pull request in Catalyst. [sc-69069] --------- Co-authored-by: ringo-but-quantum <[email protected]> Co-authored-by: Ali Asadi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: We would like Catalyst to optimize the first instance of
qml.StatePrepby just setting the state vector in PennyLane lightning.Description of the Change: To achieve this, we set a flag in the TOML files where it denotes whether the value for the flag
skip_initial_state_prepused during decomposition. This flag is already in PennyLane and will skip the initial state preparation.There are other ways to achieve this but this is the least invasive way to do so. Some other alternatives that were discussed:
qmlOperation in the list of supported operations on the device, even though it would never be seen except when using with Catalyst.The way this was achieved was not to create a new
qmlOperation, only an JAXPR/MLIR operation and bindStatePrepto this JAXPR operation and lower it through MLIR. So, no newqmloperations.Benefits: Optimization
Possible Drawbacks: More flags. No one likes flags.
Related GitHub Issues: Will be followed by this PennyLaneAI/catalyst#955 pull request in Catalyst.
[sc-69069]