-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize StateVectorLQubitManaged CTOR #811
Conversation
…wires, num_shots).
Co-authored-by: Ali Asadi <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #811 +/- ##
==========================================
- Coverage 98.60% 92.32% -6.28%
==========================================
Files 114 73 -41
Lines 17658 11172 -6486
==========================================
- Hits 17412 10315 -7097
- Misses 246 857 +611 ☔ View full report in Codecov by Sentry. |
pennylane_lightning/core/src/simulators/lightning_qubit/StateVectorLQubitManaged.hpp
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
pennylane_lightning/core/src/simulators/lightning_qubit/StateVectorLQubitManaged.hpp
Show resolved
Hide resolved
pennylane_lightning/core/src/simulators/lightning_qubit/StateVectorLQubitManaged.hpp
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice Job. brief change with good results
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
tests
directory!All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs
.Ensure that the test suite passes, by running
make test
.Add a new entry to the
.github/CHANGELOG.md
file, summarizing thechange, and including a link back to the PR.
Ensure that code is properly formatted by running
make format
.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context:
Profiling a simple script similar to
it appears some time is wasted in a duplicate
memset
call when invoking theStateVectorC128
constructor.Description of the Change:
Directly set the 0th element to
1.0
.Benefits:

Faster
StateVectorC128
initialization.Possible Drawbacks:
Related GitHub Issues:
[sc-69660]