-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create v0.37.0 RC branch #777
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v0.37.0_base #777 +/- ##
================================================
+ Coverage 90.30% 99.12% +8.81%
================================================
Files 81 143 +62
Lines 11360 20793 +9433
================================================
+ Hits 10259 20611 +10352
+ Misses 1101 182 -919 ☔ View full report in Codecov by Sentry. |
…772) **Context:** Allowing the `qml.device("lightning.gpu", wires=...)._dp` argument, which is a python `DevPools()` object to be pickle-able through the C++ layer. **Description of the Change:** - Updated Devpools object to have a `refresh()` method - Updated TSQueue to have a clear method - Add bindings for pickle to DevPool --------- Co-authored-by: ringo-but-quantum <[email protected]> Co-authored-by: Ali Asadi <[email protected]>
…772) **Context:** Allowing the `qml.device("lightning.gpu", wires=...)._dp` argument, which is a python `DevPools()` object to be pickle-able through the C++ layer. **Description of the Change:** - Updated Devpools object to have a `refresh()` method - Updated TSQueue to have a clear method - Add bindings for pickle to DevPool --------- Co-authored-by: ringo-but-quantum <[email protected]> Co-authored-by: Ali Asadi <[email protected]>
git+https://github.com/PennyLaneAI/pennylane.git@master | ||
git+https://github.com/PennyLaneAI/pennylane.git@v0.37.0-rc0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The requirements also need update.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd agree with that, but in the guidance docs we suggest it should be done after the release. This makes sense since master
could have diverged and be incompatible at this point. So on the one hand, all we care about on the release branch (e.g. v0.37.0_release
) is that wheels will work with PennyLane v0.37.0 (i.e. v0.37.0-rc0
), but on the other hand we want this back to master
when we merge the RC branch changes into master
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We had problems with this last release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was the resolution brought about changing to master
or keeping to v0.37.0-rc0
?
git+https://github.com/PennyLaneAI/pennylane.git@master No newline at end of file | ||
git+https://github.com/PennyLaneAI/pennylane.git@v0.37.0-rc0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one too.
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
tests
directory!All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs
.Ensure that the test suite passes, by running
make test
.Add a new entry to the
.github/CHANGELOG.md
file, summarizing thechange, and including a link back to the PR.
Ensure that code is properly formatted by running
make format
.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context:
v0.37.0 release branch.
Description of the Change:
Includes a few cherry-picks, bug fixes, etc. for the release of v0.37.0.
Benefits:
Possible Drawbacks:
Related GitHub Issues: