Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create v0.37.0 RC branch #777

Closed
wants to merge 17 commits into from
Closed

Create v0.37.0 RC branch #777

wants to merge 17 commits into from

Conversation

vincentmr
Copy link
Contributor

@vincentmr vincentmr commented Jun 25, 2024

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    tests directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the .github/CHANGELOG.md file, summarizing the
    change, and including a link back to the PR.

  • Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context:
v0.37.0 release branch.

Description of the Change:
Includes a few cherry-picks, bug fixes, etc. for the release of v0.37.0.

Benefits:

Possible Drawbacks:

Related GitHub Issues:

@vincentmr vincentmr added the do not merge Do not merge PR until this label is removed label Jun 25, 2024
Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.12%. Comparing base (042fa7c) to head (240b7ed).

Additional details and impacted files
@@               Coverage Diff                @@
##           v0.37.0_base     #777      +/-   ##
================================================
+ Coverage         90.30%   99.12%   +8.81%     
================================================
  Files                81      143      +62     
  Lines             11360    20793    +9433     
================================================
+ Hits              10259    20611   +10352     
+ Misses             1101      182     -919     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vincentmr vincentmr added the ci:use-multi-gpu-runner Enable usage of Multi-GPU runner for this Pull Request label Jun 25, 2024
vincentmr and others added 5 commits June 25, 2024 19:25
…772)

**Context:**
Allowing the `qml.device("lightning.gpu", wires=...)._dp` argument,
which is a python `DevPools()` object to be pickle-able through the C++
layer.

**Description of the Change:**
- Updated Devpools object to have a `refresh()` method
- Updated TSQueue to have a clear method 
- Add bindings for pickle to DevPool

---------

Co-authored-by: ringo-but-quantum <[email protected]>
Co-authored-by: Ali Asadi <[email protected]>
…772)

**Context:**
Allowing the `qml.device("lightning.gpu", wires=...)._dp` argument,
which is a python `DevPools()` object to be pickle-able through the C++
layer.

**Description of the Change:**
- Updated Devpools object to have a `refresh()` method
- Updated TSQueue to have a clear method
- Add bindings for pickle to DevPool

---------

Co-authored-by: ringo-but-quantum <[email protected]>
Co-authored-by: Ali Asadi <[email protected]>
@vincentmr vincentmr marked this pull request as ready for review July 3, 2024 12:53
@vincentmr vincentmr changed the base branch from master to v0.37.0_base July 3, 2024 13:14
@vincentmr vincentmr added the ci:build_wheels Activate wheel building. label Jul 4, 2024
@vincentmr vincentmr requested review from maliasadi, AmintorDusko and multiphaseCFD and removed request for maliasadi July 8, 2024 13:04
git+https://github.com/PennyLaneAI/pennylane.git@master
git+https://github.com/PennyLaneAI/pennylane.git@v0.37.0-rc0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The requirements also need update.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd agree with that, but in the guidance docs we suggest it should be done after the release. This makes sense since master could have diverged and be incompatible at this point. So on the one hand, all we care about on the release branch (e.g. v0.37.0_release) is that wheels will work with PennyLane v0.37.0 (i.e. v0.37.0-rc0), but on the other hand we want this back to master when we merge the RC branch changes into master.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We had problems with this last release.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was the resolution brought about changing to master or keeping to v0.37.0-rc0?

Comment on lines 6 to 7
git+https://github.com/PennyLaneAI/pennylane.git@master No newline at end of file
git+https://github.com/PennyLaneAI/pennylane.git@v0.37.0-rc0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one too.

@vincentmr vincentmr removed the request for review from multiphaseCFD July 8, 2024 13:31
@vincentmr vincentmr closed this Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:build_wheels Activate wheel building. ci:use-multi-gpu-runner Enable usage of Multi-GPU runner for this Pull Request do not merge Do not merge PR until this label is removed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants