-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Scipy v1.14 #776
Conversation
…se the deprecated pkgutil.ImpImporter
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #776 +/- ##
==========================================
+ Coverage 92.90% 98.47% +5.56%
==========================================
Files 126 109 -17
Lines 18477 15794 -2683
==========================================
- Hits 17166 15553 -1613
+ Misses 1311 241 -1070 ☔ View full report in Codecov by Sentry. |
…sed with a prefix .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one q:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @maliasadi .
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
tests
directory!All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs
.Ensure that the test suite passes, by running
make test
.Add a new entry to the
.github/CHANGELOG.md
file, summarizing thechange, and including a link back to the PR.
Ensure that code is properly formatted by running
make format
.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context:
SciPy v1.14 packages
libopenblas
aslibscipy_openblas
on Linux and OpenBlas symbols are now exposed with a prefixscipy_
.Description of the Change:
Update
UtilLinearAlg.hpp
to check the library name before getting openblas symbols.Benefits:
Support
scipy
v0.14Possible Drawbacks:
Related GitHub Issues: