Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Scipy v1.14 #776

Merged
merged 7 commits into from
Jun 25, 2024
Merged

Add support for Scipy v1.14 #776

merged 7 commits into from
Jun 25, 2024

Conversation

maliasadi
Copy link
Member

@maliasadi maliasadi commented Jun 25, 2024

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    tests directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the .github/CHANGELOG.md file, summarizing the
    change, and including a link back to the PR.

  • Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context:
SciPy v1.14 packages libopenblas as libscipy_openblas on Linux and OpenBlas symbols are now exposed with a prefix scipy_.

Description of the Change:
Update UtilLinearAlg.hpp to check the library name before getting openblas symbols.

Benefits:
Support scipy v0.14

Possible Drawbacks:

Related GitHub Issues:

@maliasadi maliasadi added the ci:build_wheels Activate wheel building. label Jun 25, 2024
Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.47%. Comparing base (f097557) to head (eaebd86).
Report is 95 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #776      +/-   ##
==========================================
+ Coverage   92.90%   98.47%   +5.56%     
==========================================
  Files         126      109      -17     
  Lines       18477    15794    -2683     
==========================================
- Hits        17166    15553    -1613     
+ Misses       1311      241    -1070     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maliasadi maliasadi changed the title Fix Python 3.12 CI Failures Add support for Scipy v1.14 Jun 25, 2024
@maliasadi maliasadi marked this pull request as ready for review June 25, 2024 16:01
@maliasadi maliasadi requested a review from a team June 25, 2024 16:11
Copy link
Member

@mlxd mlxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one q:

@vincentmr vincentmr self-requested a review June 25, 2024 17:06
@maliasadi maliasadi requested a review from mlxd June 25, 2024 17:09
@mlxd mlxd mentioned this pull request Jun 25, 2024
5 tasks
Copy link
Contributor

@vincentmr vincentmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @maliasadi .

@maliasadi maliasadi merged commit adef274 into master Jun 25, 2024
111 checks passed
@maliasadi maliasadi deleted the fix-py312-ci-failures branch June 25, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:build_wheels Activate wheel building.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants