Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create cuda utils module #676

Merged
merged 17 commits into from
Apr 12, 2024
Merged

Create cuda utils module #676

merged 17 commits into from
Apr 12, 2024

Conversation

multiphaseCFD
Copy link
Member

@multiphaseCFD multiphaseCFD commented Apr 11, 2024

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    tests directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the .github/CHANGELOG.md file, summarizing the
    change, and including a link back to the PR.

  • Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context:

Create CUDA_Utils module

Description of the Change:

All the common components (in lightning_gpu/utils/) that can be shared with other cuda-based backend are move to /src/utils/cuda_utils/.

Note that the lightning_gpu_util is still kept to not break the cmake script. lightning_gpu_utils is only required for C++ layer unit tests of lightning_gpu after applying changes in this PR.

Benefits:

Possible Drawbacks:

Related GitHub Issues:

Copy link

codecov bot commented Apr 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.06%. Comparing base (8ee3e00) to head (963f3ef).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #676      +/-   ##
==========================================
+ Coverage   97.10%   99.06%   +1.96%     
==========================================
  Files         150      207      +57     
  Lines       19410    29454   +10044     
==========================================
+ Hits        18848    29180   +10332     
+ Misses        562      274     -288     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@multiphaseCFD multiphaseCFD marked this pull request as ready for review April 11, 2024 20:52
@multiphaseCFD multiphaseCFD added ci:use-multi-gpu-runner Enable usage of Multi-GPU runner for this Pull Request ci:build_wheels Activate wheel building. labels Apr 11, 2024
@multiphaseCFD multiphaseCFD changed the title [WIP] Create cuda utils module Create cuda utils module Apr 11, 2024
@multiphaseCFD multiphaseCFD requested a review from a team April 11, 2024 20:56
Copy link
Member

@maliasadi maliasadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @multiphaseCFD! Just a few minor suggestions, but it should be good to merge at any time.

Copy link
Contributor

@vincentmr vincentmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice review by @maliasadi , I don't have much to add here. LGTM, but maybe we can simplify a bit by including CUDA utils conditionally in the generic utils.

@multiphaseCFD
Copy link
Member Author

Nice review by @maliasadi , I don't have much to add here. LGTM, but maybe we can simplify a bit by including CUDA utils conditionally in the generic utils.

Thanks @vincentmr ! Agree and just update the PR by linking cuda_utils to lightning_utils.

Copy link
Member

@maliasadi maliasadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @multiphaseCFD! 🏗️

@multiphaseCFD multiphaseCFD merged commit 2028317 into master Apr 12, 2024
85 checks passed
@multiphaseCFD multiphaseCFD deleted the create_cuda_utils_module branch April 12, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:build_wheels Activate wheel building. ci:use-multi-gpu-runner Enable usage of Multi-GPU runner for this Pull Request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants