Add support for LinearCombination
#649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
maliasadi
reviewed
Mar 26, 2024
maliasadi
reviewed
Mar 26, 2024
mudit2812
commented
Mar 26, 2024
mudit2812
commented
Mar 26, 2024
mudit2812
commented
Mar 26, 2024
mudit2812
commented
Mar 26, 2024
mudit2812
commented
Mar 26, 2024
Co-authored-by: Ali Asadi <[email protected]>
Co-authored-by: Ali Asadi <[email protected]>
* Comment triggers. * pytest -x * trigger ci * Do not skip comp for LQ. * Revert triggers * Revert changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
PennyLane is switching to the new Operator Arithmetic as the default. This PR updates Lightning to be compatible with this change.
Description of the Change:
QuantumScriptSerializerto be smarter with new op math, and to accommodateLinearCombination.Sum,Prod, andSProdinstances when validating for adjoint diff. This function was the same between LKokkos and LGPU, so I moved this logic toLightningBase.Benefits:
New op math as the default works with Lightning.
Possible Drawbacks:
Serialization with new op math has some weird nesting. Will be addressed in a follow up PR.
Related GitHub Issues:
Related work in PennyLane:
#5335, #5216, #5269