Add LightningQubit2 class
#607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello. You may have forgotten to update the changelog!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #607 +/- ##
==========================================
+ Coverage 98.44% 98.71% +0.26%
==========================================
Files 172 173 +1
Lines 24883 24466 -417
==========================================
- Hits 24497 24152 -345
+ Misses 386 314 -72 ☔ View full report in Codecov by Sentry. |
albi3ro
changed the base branch from
master
to
lightning-qubit2-add-simulate
vincentmr
reviewed
Mar 14, 2024
mudit2812
reviewed
Mar 14, 2024
mudit2812
reviewed
Mar 14, 2024
mudit2812
reviewed
Mar 15, 2024
vincentmr
approved these changes
Mar 15, 2024
There was a problem hiding this comment.
This is massive :) Happy to approve the PR at this point. Thanks for all the hard work @mudit2812 and @albi3ro .
AmintorDusko
approved these changes
Mar 15, 2024
There was a problem hiding this comment.
Great work here! Thank you @mudit2812, @albi3ro and @vincentmr for the awesome work!
Please don't forget the changelog!
Co-authored-by: Ali Asadi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
PennyLane has added a new device interface that will potentially allow for adjoint differentiation to be enabled with lightning by default.
This PR adds the Python API for such a change.
Description of the Change:
This PR adds a
LightningQubit2class.It relies on three methods,
simulate,jacobianandsimulate_and_jacobianRight now, the device restricts itself to analytic simulations.
Benefits:
Users can get the most performant choices automatically, without having to manually request adjoint differentiation.
The internal simulation details are also fully abstracted away from the required device interface, allowing for change and optimizations as the technical details require.
Possible Drawbacks:
This will be a major breaking change to the interface, and users may be relying on the specific names of methods.
Shortcut Stories:
[sc-56080]