do not use measurementprocess.name #605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello. You may have forgotten to update the changelog!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #605 +/- ##
==========================================
- Coverage 98.68% 98.68% -0.01%
==========================================
Files 168 169 +1
Lines 24191 24344 +153
==========================================
+ Hits 23874 24023 +149
- Misses 317 321 +4 ☔ View full report in Codecov by Sentry. |
timmysilv
commented
Jan 31, 2024
vincentmr
approved these changes
Jan 31, 2024
AmintorDusko
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
MeasurementProcess.namehas been deprecated, and we should avoid using it. Unfortunately, sometimes they disguise as observables. This is one of those times, and it makes PennyLane CI fail when we enable deprecation-warnings-as-errorsDescription of the Change:
Just use
isinstanceto not check the name in case it's not an observable.Benefits:
Possible Drawbacks:
N/A
Related GitHub Issues:
PennyLaneAI/pennylane#5122, recently introduced in #601