-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Docker's Lightning version & add Docker build workflow. #593
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #593 +/- ##
==========================================
- Coverage 98.96% 98.67% -0.30%
==========================================
Files 169 169
Lines 24308 24308
==========================================
- Hits 24056 23985 -71
- Misses 252 323 +71 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @vincentmr
Just 2 comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @vincentmr, thank you for that!
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
tests
directory!All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs
.Ensure that the test suite passes, by running
make test
.Add a new entry to the
.github/CHANGELOG.md
file, summarizing thechange, and including a link back to the PR.
Ensure that code is properly formatted by running
make format
.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context:
The Docker target
lightning-kokkos-cuda
fails to build because CMake does not properly resolvescuda_driver
.Description of the Change:
Since it only happens when building this Docker target, a simple patch of
cmake/support_kokkos.cmake
is introduced.A CI workflow building and pushing to Docker Hub is also added to streamline the release procedure. The workflow is not triggered by
pull_request
, but I have verified it works here.Benefits:
Possible Drawbacks:
Related GitHub Issues: