Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenGraph social preview #574

Merged
merged 7 commits into from
Dec 12, 2023
Merged

Add OpenGraph social preview #574

merged 7 commits into from
Dec 12, 2023

Conversation

AmintorDusko
Copy link
Contributor

@AmintorDusko AmintorDusko commented Dec 11, 2023

Context: When posting links to the docs on social media, there is no social media preview, as there was no OpenGraph metadata generated by Sphinx.

Description of the Change:

  • Adds matplotlib and sphinxext-opengraph as doc requirements

  • configures conf.py to set the OpenGraph information, in particular,

Benefits: Better social media coverage.

Preview

Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit .github/CHANGELOG.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

Copy link

codecov bot commented Dec 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (502fecb) 98.96% compared to head (fb1b2ab) 99.09%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #574      +/-   ##
==========================================
+ Coverage   98.96%   99.09%   +0.12%     
==========================================
  Files         167      201      +34     
  Lines       24132    29203    +5071     
==========================================
+ Hits        23883    28938    +5055     
- Misses        249      265      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AmintorDusko AmintorDusko changed the title Add OpenGraph Add OpenGraph social preview Dec 11, 2023
@AmintorDusko AmintorDusko marked this pull request as ready for review December 12, 2023 14:18
Copy link
Member

@josh146 josh146 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AmintorDusko!

@AmintorDusko AmintorDusko requested a review from a team December 12, 2023 14:35
@AmintorDusko
Copy link
Contributor Author

[sc-50785]

Copy link
Member

@multiphaseCFD multiphaseCFD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Thanks @AmintorDusko !

Copy link
Contributor

@vincentmr vincentmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @AmintorDusko !

@AmintorDusko AmintorDusko added the ci:use-multi-gpu-runner Enable usage of Multi-GPU runner for this Pull Request label Dec 12, 2023
@AmintorDusko AmintorDusko removed the ci:use-multi-gpu-runner Enable usage of Multi-GPU runner for this Pull Request label Dec 12, 2023
@AmintorDusko AmintorDusko merged commit 8770a96 into master Dec 12, 2023
@AmintorDusko AmintorDusko deleted the add/OpenGraph branch December 12, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants