Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Hermitian support for shot-noise & LAPACK linking #569

Merged
merged 255 commits into from
Jan 12, 2024

Conversation

multiphaseCFD
Copy link
Member

@multiphaseCFD multiphaseCFD commented Dec 5, 2023

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    tests directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the .github/CHANGELOG.md file, summarizing the
    change, and including a link back to the PR.

  • Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context:

Add Hermitian observable support for stochastic measurement to C++ layer. LAPACK is required to solve eigenvalues and the unitary of a given Hermitian. The main challenge of this task is LAPACK linking for Windows system. To solve this issue, vcpkg is used to install LAPACK and the only thing Windows users need to do is to specify the path to set CMAKE_TOOLCHAIN_FILE with -DCMAKE_TOOLCHAIN_FILE=<vcpkg-root>/scripts/buildsystems/vcpkg.cmake.

Description of the Change:

C++ backends now can link against LAPACK.

Benefits:

Possible Drawbacks:

Related GitHub Issues:

Copy link
Contributor

@AmintorDusko AmintorDusko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Shuli nice work so far. Let me know when updates are done and CIs successful and I will give one more round of review.

Copy link
Member

@maliasadi maliasadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job @multiphaseCFD! 🎉

Copy link
Contributor

@AmintorDusko AmintorDusko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing more to add. Nice work!

@multiphaseCFD multiphaseCFD merged commit f591388 into master Jan 12, 2024
@multiphaseCFD multiphaseCFD deleted the refactor_obs_base branch January 12, 2024 18:36
@Alex-Preciado Alex-Preciado changed the title add Hermitian support for shot-noise & LAPACK linking Add Hermitian support for shot-noise & LAPACK linking Feb 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:use-multi-gpu-runner Enable usage of Multi-GPU runner for this Pull Request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants