Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Very small typo in devices doc page #563

Merged
merged 5 commits into from
Nov 21, 2023
Merged

Very small typo in devices doc page #563

merged 5 commits into from
Nov 21, 2023

Conversation

isaacdevlugt
Copy link
Contributor

No description provided.

Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit .github/CHANGELOG.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

Copy link

codecov bot commented Nov 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (461f73b) 98.69% compared to head (ec37eab) 96.96%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #563      +/-   ##
==========================================
- Coverage   98.69%   96.96%   -1.73%     
==========================================
  Files         168      145      -23     
  Lines       22585    17707    -4878     
==========================================
- Hits        22290    17170    -5120     
- Misses        295      537     +242     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@AmintorDusko AmintorDusko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @isaacdevlugt. Please add your name to the changelog as a contributor.

Copy link
Member

@multiphaseCFD multiphaseCFD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @isaacdevlugt ! Looks good to me.

@AmintorDusko
Copy link
Contributor

@isaacdevlugt, feel free to merge your PR when ready. The coverage problems are related to the absence of GPU tests.

@isaacdevlugt isaacdevlugt merged commit 655d537 into master Nov 21, 2023
@isaacdevlugt isaacdevlugt deleted the typo-devices-doc branch November 21, 2023 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants