Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Python 3.12 wheel builds #541

Merged
merged 17 commits into from
Jan 3, 2024
Merged

Add support for Python 3.12 wheel builds #541

merged 17 commits into from
Jan 3, 2024

Conversation

mlxd
Copy link
Member

@mlxd mlxd commented Oct 31, 2023

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    tests directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the .github/CHANGELOG.md file, summarizing the
    change, and including a link back to the PR.

  • Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context: This PR updates the maximum tested version of Python to 3.12, and enables build support for wheels with said version.

Description of the Change: Add support for Python 3.12 builds and testing. Upgrade pybind11. Upgrade cibuildwheel.

Benefits: Adds support for Python 3.12 wheels.

Possible Drawbacks: Additional effort during release time due to extra Python versions.

Related GitHub Issues:

Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit .github/CHANGELOG.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

Copy link

codecov bot commented Nov 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bce3b09) 98.66% compared to head (3d16d9e) 98.66%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #541   +/-   ##
=======================================
  Coverage   98.66%   98.66%           
=======================================
  Files         167      167           
  Lines       23964    23964           
=======================================
  Hits        23645    23645           
  Misses        319      319           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mlxd mlxd marked this pull request as ready for review January 2, 2024 20:00
@mlxd mlxd requested review from a team January 2, 2024 20:04
Copy link
Member

@multiphaseCFD multiphaseCFD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks @mlxd !

@mlxd mlxd requested a review from maliasadi January 3, 2024 14:41
Copy link
Member

@maliasadi maliasadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@mlxd mlxd merged commit dfad9d7 into master Jan 3, 2024
@mlxd mlxd deleted the update/py312 branch January 3, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants