Accelerate multi-qubit gates #490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ata` to work with devices. M pennylane_lightning/core/src/simulators/lightning_kokkos/StateVectorKokkos.hpp; `applyMatrix` bugfix: use intermediate hostview to copy matrix data; same bugfix for `getDataVector`. M pennylane_lightning/core/src/simulators/lightning_kokkos/algorithms/AdjointJacobianKokkos.hpp; use copy constructor. M pennylane_lightning/core/src/simulators/lightning_kokkos/measurements/MeasurementsKokkos.hpp; use copy constructor. M pennylane_lightning/core/src/simulators/lightning_kokkos/observables/ObservablesKokkos.hpp; use copy constructor. M requirements-dev.txt; add clang-format-14.
… vector data in adjoint-diff.
…calls into two templated methods. Call specialized expval methods when possible. Remove obsolete 'Apply directly' tests.
…alueMultiQubitOpFunctor.
I'm unsure when we'll have a runner with CUDA-12 (and not sure we'll have any runner with HIP-capable devices any time soon), so could we move forward with this PR nevertheless? |
yea, sounds good to me! |
mlxd
reviewed
Sep 7, 2023
..._lightning/core/src/simulators/lightning_kokkos/gates/tests/Test_StateVectorKokkos_Param.cpp
Outdated
Show resolved
Hide resolved
pennylane_lightning/core/src/simulators/lightning_kokkos/StateVectorKokkos.hpp
Show resolved
Hide resolved
pennylane_lightning/core/src/simulators/lightning_kokkos/StateVectorKokkos.hpp
Show resolved
Hide resolved
…/tests/Test_StateVectorKokkos_Param.cpp Co-authored-by: Lee James O'Riordan <[email protected]>
AmintorDusko
reviewed
Sep 7, 2023
pennylane_lightning/core/src/simulators/lightning_kokkos/gates/GateFunctorsParam.hpp
Outdated
Show resolved
Hide resolved
pennylane_lightning/core/src/simulators/lightning_kokkos/gates/GateFunctorsParam.hpp
Outdated
Show resolved
Hide resolved
AmintorDusko
previously approved these changes
Sep 8, 2023
AmintorDusko
reviewed
Sep 8, 2023
pennylane_lightning/core/src/simulators/lightning_kokkos/measurements/ExpValFunctors.hpp
Show resolved
Hide resolved
AmintorDusko
reviewed
Sep 8, 2023
pennylane_lightning/core/src/simulators/lightning_kokkos/measurements/ExpValFunctors.hpp
Show resolved
Hide resolved
AmintorDusko
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
testsdirectory!All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs.Ensure that the test suite passes, by running
make test.Add a new entry to the
.github/CHANGELOG.mdfile, summarizing thechange, and including a link back to the PR.
Ensure that code is properly formatted by running
make format.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context:
This PR is a follow-up on #489 . The general scheme for multi-qubit gates uses three layers of parallelism with team policies. This introduces several parameters which should be tuned for optimal performance, but are currently left to Kokkos' heuristics to decide. On the other hand, the straightforward range policy-based scheme of the 1- and 2-qubit kernels outperforms the general scheme significantly.
I introduce specialized 3- to 5-qubit kernels. I draw the following conclusion:
The following figures show timings to apply a
QubitUnitaryfor OPENMP, CUDA and HIP respectively.Description of the Change:
Introduce specialized 3- to 5-qubit unitary gate kernels. Refactor
applyMultiQubitOpwrapper inStateVectorKokkos.hpp. Functors are not templated oninverseanymore, taking the conjugate-transpose once and for all upon enteringapplyMultiQubitOpinstead of on-the-fly for each element of the for loop. Add few tests.Benefits:
Faster
QubitUnitary, especially for 3+-qubit observables on GPU-devices.Possible Drawbacks:
None
Related GitHub Issues: