No longer in-place modify input to apply

[albi3ro]

In Pennylane PR #4485, tape.operations will no longer be the sum of tape._prep and tape._ops.

This means any modification of the tape.operations list will mutate the tape itself, instead of a shallow copy of its contents.

A basic example of this can be shown with the below list manipulations:

>>> a = [1]
>>> b = [2]
>>> c = a+b
>>> c[0] = 5
>>> c
[5, 2]
>>> a
[1]
>>> d = a
>>> d[0] = 5
>>> a
[5]

Long story short, we do not want to in-place modify the operations list anymore. So instead of using del operations[0], I simply select out the contents from index one onward.

[github-actions]

Hello. You may have forgotten to update the changelog!
Please edit .github/CHANGELOG.md with:

• A one-to-two sentence description of the change. You may include a small working example for new features.
• A link back to this PR.
• Your name (or GitHub username) in the contributors section.

[codecov]

Codecov Report

Merging #474 (ca217cb) into merge/monorepo (7b6f230) will decrease coverage by 0.43%.
Report is 7 commits behind head on merge/monorepo.
The diff coverage is 100.00%.

@@                Coverage Diff                 @@
##           merge/monorepo     #474      +/-   ##
==================================================
- Coverage           97.21%   96.79%   -0.43%     
==================================================
  Files                 141      142       +1     
  Lines               16280    16420     +140     
==================================================
+ Hits                15827    15894      +67     
- Misses                453      526      +73     

Files Changed	Coverage Δ
...ane_lightning/lightning_kokkos/lightning_kokkos.py	93.97% <100.00%> (ø)
...ylane_lightning/lightning_qubit/lightning_qubit.py	92.54% <100.00%> (ø)

... and 20 files with indirect coverage changes

[vincentmr]

Looks good to me. Thanks @albi3ro !

[vincentmr]

@albi3ro Don't you also want this fixed on master?

[AmintorDusko]

Hi @albi3ro, this is a sensible update.
Thank you for that.

[AmintorDusko]

@albi3ro, feel free to merge it. You can ignore the CI fails.

[albi3ro]

@albi3ro Don't you also want this fixed on master?

I can open up a PR to master if need be.

[vincentmr]

I can open up a PR to master if need be.

I can do it too, I meant do you need it out asap (for example if this is a blocker in some CI pulling lightning@master)? Because merge/monorepo will take some more time.

[mlxd]

I can open up a PR to master if need be.

I can do it too, I meant do you need it out asap (for example if this is a blocker in some CI pulling lightning@master)? Because merge/monorepo will take some more time.

Let's get it into master now too then, as the CI is likely going to be heavily hit today, and having the most recent version will be worthwhile.

[vincentmr]

I can open up a PR to master if need be.

I can do it too, I meant do you need it out asap (for example if this is a blocker in some CI pulling lightning@master)? Because merge/monorepo will take some more time.

Let's get it into master now too then, as the CI is likely going to be heavily hit today, and having the most recent version will be worthwhile.

Will take care of it.