-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SPVM routine for when kokkos not available. #465
Conversation
Hello. You may have forgotten to update the changelog!
|
Codecov Report
@@ Coverage Diff @@
## master #465 +/- ##
==========================================
+ Coverage 99.82% 99.91% +0.08%
==========================================
Files 50 50
Lines 4667 4671 +4
==========================================
+ Hits 4659 4667 +8
+ Misses 8 4 -4
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some quick comments for the next week.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So far looks good to me. I will check in more depth later.
Hi, @vincentmr. It appears that the CI may have become stuck, so you may want to try re-triggering it. |
Co-authored-by: Amintor Dusko <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Vincent --- no more thoughts from me. Happy to approve.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job @vincentmr !
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
tests
directory!All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs
.Ensure that the test suite passes, by running
make test
.Add a new entry to the
.github/CHANGELOG.md
file, summarizing thechange, and including a link back to the PR.
Ensure that code is properly formatted by running
make format
.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context:
Kokkos & Kokkos-kernels (serial backends) are used only for a single sparse matrix/dense vector operation. This is a
Description of the Change:
Add simple spvm implementation when
ENABLE_KOKKOS=OFF
.Benefits:
No need to pull large dependencies Kokkos & Kokkos-kernels. SparseHamiltonian always supported.
Possible Drawbacks:
It could be slower, although the (serial) code is so simple that there is little room for optimization and that is unlikely.
Related GitHub Issues: