Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace set-output #437

Merged
merged 9 commits into from
Apr 18, 2023
Merged

Replace set-output #437

merged 9 commits into from
Apr 18, 2023

Conversation

vincentmr
Copy link
Contributor

@vincentmr vincentmr commented Apr 17, 2023

Context:
save-state and set-output commands will be deprecated.
https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Description of the Change:
Use new env files instead of save-state and set-output commands.

Benefits:
CI will keep running.

Possible Drawbacks:
None.

Related GitHub Issues:
None.

@vincentmr vincentmr marked this pull request as ready for review April 17, 2023 14:54
@vincentmr vincentmr requested a review from multiphaseCFD April 17, 2023 15:40
@codecov
Copy link

codecov bot commented Apr 17, 2023

Codecov Report

Merging #437 (bec41de) into master (e44a6af) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #437   +/-   ##
=======================================
  Coverage   99.82%   99.82%           
=======================================
  Files          50       50           
  Lines        4635     4635           
=======================================
  Hits         4627     4627           
  Misses          8        8           
Impacted Files Coverage Δ
pennylane_lightning/_version.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@vincentmr vincentmr requested a review from AmintorDusko April 17, 2023 17:47
Copy link
Contributor

@AmintorDusko AmintorDusko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!

Copy link
Member

@multiphaseCFD multiphaseCFD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks @vincentmr !

@vincentmr vincentmr merged commit e94907f into master Apr 18, 2023
@vincentmr vincentmr deleted the deprecate/save-state branch April 18, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants