Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for clang-tidy 16 #429

Merged
merged 5 commits into from
Apr 14, 2023
Merged

Fix for clang-tidy 16 #429

merged 5 commits into from
Apr 14, 2023

Conversation

chaeyeunpark
Copy link
Contributor

@chaeyeunpark chaeyeunpark commented Apr 10, 2023

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    tests directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the .github/CHANGELOG.md file, summarizing the
    change, and including a link back to the PR.

  • Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context: Some additional criteria in clang-tidy-16 do not like our current codebase. This simple PR fixes it. Still, we do not update the clang-tidy version of the CI yet.

Description of the Change:

Benefits:

Possible Drawbacks:

Related GitHub Issues:

@chaeyeunpark chaeyeunpark marked this pull request as draft April 10, 2023 18:33
@github-actions
Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit .github/CHANGELOG.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@codecov
Copy link

codecov bot commented Apr 12, 2023

Codecov Report

Merging #429 (e0645a8) into master (736f782) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #429   +/-   ##
=======================================
  Coverage   99.82%   99.82%           
=======================================
  Files          50       50           
  Lines        4634     4635    +1     
=======================================
+ Hits         4626     4627    +1     
  Misses          8        8           
Impacted Files Coverage Δ
pennylane_lightning/_version.py 100.00% <100.00%> (ø)
...ennylane_lightning/src/gates/DynamicDispatcher.hpp 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@chaeyeunpark chaeyeunpark marked this pull request as ready for review April 12, 2023 19:13
Copy link
Member

@mlxd mlxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @chaeyeunpark
Just a few quick q's

Copy link
Member

@mlxd mlxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @chaeyeunpark
Feel free to add a changelog entry and I'll be happy to approve.

Copy link
Contributor

@AmintorDusko AmintorDusko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thank you for that!

@chaeyeunpark chaeyeunpark merged commit e44a6af into master Apr 14, 2023
@chaeyeunpark chaeyeunpark deleted the fix_for_clang_tidy_16 branch April 14, 2023 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants