-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change AVX2/512 kernel infrastructure for additional gate/generator operations #404
Conversation
Hello. You may have forgotten to update the changelog!
|
…tning into fix_avx_infra
Codecov Report
@@ Coverage Diff @@
## master #404 +/- ##
=======================================
Coverage 99.88% 99.88%
=======================================
Files 49 49
Lines 4463 4463
=======================================
Hits 4458 4458
Misses 5 5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some comments for now. I'm still going through it, though.
pennylane_lightning/src/gates/cpu_kernels/avx_common/AVXUtil.hpp
Outdated
Show resolved
Hide resolved
pennylane_lightning/src/gates/cpu_kernels/avx_common/AVXUtil.hpp
Outdated
Show resolved
Hide resolved
pennylane_lightning/src/gates/cpu_kernels/avx_common/AVXUtil.hpp
Outdated
Show resolved
Hide resolved
pennylane_lightning/src/gates/cpu_kernels/avx_common/AVXUtil.hpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More suggestions.
pennylane_lightning/src/gates/cpu_kernels/avx_common/ApplyCNOT.hpp
Outdated
Show resolved
Hide resolved
pennylane_lightning/src/gates/cpu_kernels/avx_common/ApplyCNOT.hpp
Outdated
Show resolved
Hide resolved
pennylane_lightning/src/gates/cpu_kernels/avx_common/ApplyPhaseShift.hpp
Outdated
Show resolved
Hide resolved
pennylane_lightning/src/gates/cpu_kernels/avx_common/ApplyPhaseShift.hpp
Outdated
Show resolved
Hide resolved
Thanks @chaeyeunpark for the nice work! Just left a few comments. |
[sc-31399] |
Co-authored-by: Amintor Dusko <[email protected]>
…tning into fix_avx_infra
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @chaeyeunpark
Mostly some minor doc edits and a few questions
pennylane_lightning/src/gates/cpu_kernels/avx_common/AVXUtil.hpp
Outdated
Show resolved
Hide resolved
pennylane_lightning/src/gates/cpu_kernels/avx_common/ApplyPhaseShift.hpp
Show resolved
Hide resolved
pennylane_lightning/src/gates/cpu_kernels/avx_common/SingleQubitGateHelper.hpp
Outdated
Show resolved
Hide resolved
…tning into fix_avx_infra
Co-authored-by: Lee James O'Riordan <[email protected]>
Co-authored-by: Lee James O'Riordan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @chaeyeunpark, I have nothing more to add!
Nice work, here! Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @chaeyeunpark !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again @chaeyeunpark
Nothing new to add from me.
Be sure to update the changelog tickbox (and changelog if you haven't)
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
tests
directory!All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs
.Ensure that the test suite passes, by running
make test
.Add a new entry to the
.github/CHANGELOG.md
file, summarizing thechange, and including a link back to the PR.
Ensure that code is properly formatted by running
make format
.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context: This PR extracts an essential structural change in #393. Especially, the
SingleQubitGateHelper
andTwoQubitGateHelper
classes for AVX2/512 gates are clarified and tested.Description of the Change:
Benefits:
Possible Drawbacks:
Related GitHub Issues: