Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change AVX2/512 kernel infrastructure for additional gate/generator operations #404

Merged
merged 31 commits into from
Feb 3, 2023

Conversation

chaeyeunpark
Copy link
Contributor

@chaeyeunpark chaeyeunpark commented Jan 23, 2023

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    tests directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the .github/CHANGELOG.md file, summarizing the
    change, and including a link back to the PR.

  • Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context: This PR extracts an essential structural change in #393. Especially, the SingleQubitGateHelper and TwoQubitGateHelper classes for AVX2/512 gates are clarified and tested.

Description of the Change:

Benefits:

Possible Drawbacks:

Related GitHub Issues:

@chaeyeunpark chaeyeunpark marked this pull request as draft January 23, 2023 20:15
@github-actions
Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit .github/CHANGELOG.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@codecov
Copy link

codecov bot commented Jan 23, 2023

Codecov Report

Merging #404 (b3ea8bc) into master (f02becc) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #404   +/-   ##
=======================================
  Coverage   99.88%   99.88%           
=======================================
  Files          49       49           
  Lines        4463     4463           
=======================================
  Hits         4458     4458           
  Misses          5        5           
Impacted Files Coverage Δ
pennylane_lightning/_version.py 100.00% <100.00%> (ø)
...gates/cpu_kernels/GateImplementationsAVXCommon.hpp 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@chaeyeunpark chaeyeunpark marked this pull request as ready for review January 24, 2023 22:20
Copy link
Contributor

@AmintorDusko AmintorDusko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments for now. I'm still going through it, though.

Copy link
Contributor

@AmintorDusko AmintorDusko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More suggestions.

@multiphaseCFD
Copy link
Member

Thanks @chaeyeunpark for the nice work! Just left a few comments.

@chaeyeunpark
Copy link
Contributor Author

[sc-31399]

@AmintorDusko AmintorDusko changed the title Change AVX2/512 kernel infrastrucure for additional gate/generator operations Change AVX2/512 kernel infrastructure for additional gate/generator operations Jan 27, 2023
Copy link
Member

@mlxd mlxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @chaeyeunpark
Mostly some minor doc edits and a few questions

Copy link
Contributor

@AmintorDusko AmintorDusko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @chaeyeunpark, I have nothing more to add!
Nice work, here! Thanks!

Copy link
Member

@multiphaseCFD multiphaseCFD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @chaeyeunpark !

@chaeyeunpark chaeyeunpark requested a review from mlxd February 3, 2023 17:42
Copy link
Member

@mlxd mlxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @chaeyeunpark
Nothing new to add from me.

Be sure to update the changelog tickbox (and changelog if you haven't)

@chaeyeunpark chaeyeunpark merged commit 7da199c into master Feb 3, 2023
@chaeyeunpark chaeyeunpark deleted the fix_avx_infra branch February 3, 2023 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants