-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update builder shield #402
Conversation
Due to a recent change in the builder shield structure, the shield fails to report on the build status of the wheels. This updates the paths to the new required structures, and creates a Linux build status shield to be reported.
Hello. You may have forgotten to update the changelog!
|
Codecov Report
@@ Coverage Diff @@
## master #402 +/- ##
=======================================
Coverage 99.88% 99.88%
=======================================
Files 49 49
Lines 4463 4463
=======================================
Hits 4458 4458
Misses 5 5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
* Update README.rst * Update README.rst
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is great work! Thanks!
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
tests
directory!All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs
.Ensure that the test suite passes, by running
make test
.Add a new entry to the
.github/CHANGELOG.md
file, summarizing thechange, and including a link back to the PR.
Ensure that code is properly formatted by running
make format
.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context: Due to a recent change in the builder shield structure, the shield fails to report on the build status of the wheels. This updates the paths to the new required structures, and creates a Linux build status shield to be reported.
Description of the Change: Updates the shield path to check builds against the x86 Linux wheels.
Benefits: Fixes the broken shield, and provides more up-dated information on the master branch & wheel building status.
Possible Drawbacks: Build for Linux and Mac/Windows may diverge in time.
Related GitHub Issues: