Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update builder shield #402

Merged
merged 7 commits into from
Jan 30, 2023
Merged

Update builder shield #402

merged 7 commits into from
Jan 30, 2023

Conversation

mlxd
Copy link
Member

@mlxd mlxd commented Jan 23, 2023

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    tests directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the .github/CHANGELOG.md file, summarizing the
    change, and including a link back to the PR.

  • Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context: Due to a recent change in the builder shield structure, the shield fails to report on the build status of the wheels. This updates the paths to the new required structures, and creates a Linux build status shield to be reported.

Description of the Change: Updates the shield path to check builds against the x86 Linux wheels.

Benefits: Fixes the broken shield, and provides more up-dated information on the master branch & wheel building status.

Possible Drawbacks: Build for Linux and Mac/Windows may diverge in time.

Related GitHub Issues:

Due to a recent change in the builder shield structure, the shield fails to report on the build status of the wheels. This updates the paths to the new required structures, and creates a Linux build status shield to be reported.
@github-actions
Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit .github/CHANGELOG.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@codecov
Copy link

codecov bot commented Jan 23, 2023

Codecov Report

Merging #402 (da0ecb6) into master (17c01cd) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #402   +/-   ##
=======================================
  Coverage   99.88%   99.88%           
=======================================
  Files          49       49           
  Lines        4463     4463           
=======================================
  Hits         4458     4458           
  Misses          5        5           
Impacted Files Coverage Δ
pennylane_lightning/_version.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mlxd mlxd mentioned this pull request Jan 25, 2023
5 tasks
* Update README.rst

* Update README.rst
Copy link
Contributor

@AmintorDusko AmintorDusko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is great work! Thanks!

@mlxd mlxd merged commit c5b7f76 into master Jan 30, 2023
@mlxd mlxd deleted the mlxd-patch-1 branch January 30, 2023 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants