-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated GCC 10.x to 11.x in CI tests #370
Conversation
Codecov Report
@@ Coverage Diff @@
## master #370 +/- ##
==========================================
- Coverage 99.88% 99.88% -0.01%
==========================================
Files 49 49
Lines 4403 4401 -2
==========================================
- Hits 4398 4396 -2
Misses 5 5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Hi @MonitSharma thank you for the PR. Can you update the PR submission guidelines:
with the details of this work, and follow the check-boxes to ensure all requirements are met. Thank you. You can also ignore the results from |
Before submittingPlease complete the following checklist when submitting a PR:
When all the above are checked, delete everything above the dashed **Context:**Updated GCC 10.x to 11.x in CI tests Description of the Change: Changed the version of the gcc and g++ from 10 to 11 Benefits: GCC can now auto-vectorize operations performing addition, subtraction, multiplication and the accumulate/subtract variants on complex numbers. Possible Drawbacks: Related GitHub Issues: none |
Thanks again @MonitSharma . Can you edit this at the top of the PR (#370 (comment)). Also, you did not complete the For the listed comments: Once this is done, we can start a review. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the effort @MonitSharma
Looks good to me! Happy to give it a first approval once the following action is complete:
I recommend that you Add a new entry to the .github/CHANGELOG.md file, summarizing the change, and including a link back to the PR.
We will not accept this as a finished PR until that step is complete :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @MonitSharma, nice work thanks.
You just need now to:
Add a new entry to the .github/CHANGELOG.md file, summarizing the change, and including a link back to the PR.
I opened another PR for adding summary and my name in the CHANGELOG.md file. I am not sure whether that does it? |
You should be able to make an edit to the changelog in this branch, and have it included as part of this PR. If you are using the Github web interface, this is likely a little trickier than cloning the repository from your branch and editing it there. However, you can use the in-browser VSCode editor by opening your branch at https://github.com/MonitSharma/pennylane-lightning/tree/patch-1 and hitting the You should be able to edit and save the changes in here into the same branch as your current work. Let me know if this helps! |
Your message was really helpful, I added the details in the CHANGELOG.md file. |
Co-authored-by: Amintor Dusko <[email protected]>
Co-authored-by: Amintor Dusko <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You addressed my questions and did a good job!
Thank you for that!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Manually updating internal CI dev trigger.
Great work @MonitSharma We can call this as approved. We will handle the version string update (Update dev version automatically) and merge this work once we update it. |
Thank You so much @mlxd and @AmintorDusko |
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
tests
directory!All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs
.Ensure that the test suite passes, by running
make test
.Add a new entry to the
.github/CHANGELOG.md
file, summarizing thechange, and including a link back to the PR.
Ensure that code is properly formatted by running
make format
.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context: Updated GCC 10.x to 11.x in CI tests
Description of the Change: Changed the version of the gcc and g++ from 10 to 11
Benefits: The update brings improved supports for newer C++ features.
Possible Drawbacks:
Related GitHub Issues: Issue