Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update clang-tools version #351

Merged
merged 7 commits into from
Sep 20, 2022
Merged

Update clang-tools version #351

merged 7 commits into from
Sep 20, 2022

Conversation

chaeyeunpark
Copy link
Contributor

@chaeyeunpark chaeyeunpark commented Sep 13, 2022

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    tests directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the .github/CHANGELOG.md file, summarizing the
    change, and including a link back to the PR.

  • Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context:

Description of the Change:

Benefits:

Possible Drawbacks:

Related GitHub Issues:

@github-actions
Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit .github/CHANGELOG.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 13, 2022

Test Report (Linux, Kokkos, and Kokkos Kernels) on Ubuntu

           1 files  ±       0             1 suites  ±0   1s ⏱️ -1s
       956 tests +     40         956 ✔️ +     40  0 💤 ±0  0 ±0 
234 969 runs  +1 704  234 969 ✔️ +1 704  0 💤 ±0  0 ±0 

Results for commit 80e5d53. ± Comparison against base commit 316459f.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Sep 13, 2022

Codecov Report

Merging #351 (80e5d53) into master (316459f) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #351      +/-   ##
==========================================
- Coverage   99.88%   99.88%   -0.01%     
==========================================
  Files          46       49       +3     
  Lines        3425     4191     +766     
==========================================
+ Hits         3421     4186     +765     
- Misses          4        5       +1     
Impacted Files Coverage Δ
...ng/src/gates/cpu_kernels/GateImplementationsLM.hpp 100.00% <ø> (ø)
...ng/src/gates/cpu_kernels/GateImplementationsPI.cpp 100.00% <ø> (ø)
pennylane_lightning/_version.py 100.00% <100.00%> (ø)
...ng/src/gates/cpu_kernels/GateImplementationsPI.hpp 100.00% <100.00%> (ø)
pennylane_lightning/src/simulator/Measures.hpp 100.00% <100.00%> (ø)
pennylane_lightning/src/util/Kokkos_Sparse.hpp 97.14% <0.00%> (-2.86%) ⬇️
pennylane_lightning/src/simulator/KernelMap.hpp 99.04% <0.00%> (-0.96%) ⬇️
pennylane_lightning/src/util/Util.hpp 100.00% <0.00%> (ø)
pennylane_lightning/src/util/Error.hpp 100.00% <0.00%> (ø)
pennylane_lightning/src/gates/Gates.hpp 100.00% <0.00%> (ø)
... and 31 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@chaeyeunpark chaeyeunpark changed the title Update clang-version and code accordingly Update clang-tools version Sep 13, 2022
@chaeyeunpark chaeyeunpark marked this pull request as ready for review September 14, 2022 19:27
Copy link
Contributor

@AmintorDusko AmintorDusko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice to have the clang-tools upgraded! Thanks for that!

Copy link
Member

@mlxd mlxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No concerns from me. Thanks for the update @chaeyeunpark

Also, just a reminder to all --- ensure you have the latest toolkit on your local workstation.

commit 316459f
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Tue Sep 20 09:21:01 2022 -0400

    post release version bump (#354)

    Co-authored-by: mlxd <[email protected]>
Merge remote-tracking branch 'origin/master' into update-clang-tools
@chaeyeunpark chaeyeunpark merged commit 4c6c154 into master Sep 20, 2022
@chaeyeunpark chaeyeunpark deleted the update-clang-tools branch September 20, 2022 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants