-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update clang-tools version #351
Conversation
Hello. You may have forgotten to update the changelog!
|
Test Report (Linux, Kokkos, and Kokkos Kernels) on Ubuntu 1 files ± 0 1 suites ±0 1s ⏱️ -1s Results for commit 80e5d53. ± Comparison against base commit 316459f. ♻️ This comment has been updated with latest results. |
Codecov Report
@@ Coverage Diff @@
## master #351 +/- ##
==========================================
- Coverage 99.88% 99.88% -0.01%
==========================================
Files 46 49 +3
Lines 3425 4191 +766
==========================================
+ Hits 3421 4186 +765
- Misses 4 5 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
…-lightning into update-clang-tools
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice to have the clang-tools upgraded! Thanks for that!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No concerns from me. Thanks for the update @chaeyeunpark
Also, just a reminder to all --- ensure you have the latest toolkit on your local workstation.
commit 316459f Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Tue Sep 20 09:21:01 2022 -0400 post release version bump (#354) Co-authored-by: mlxd <[email protected]> Merge remote-tracking branch 'origin/master' into update-clang-tools
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
tests
directory!All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs
.Ensure that the test suite passes, by running
make test
.Add a new entry to the
.github/CHANGELOG.md
file, summarizing thechange, and including a link back to the PR.
Ensure that code is properly formatted by running
make format
.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context:
Description of the Change:
Benefits:
Possible Drawbacks:
Related GitHub Issues: