-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce redundant tests & overheads for CI #319
Conversation
Hello. You may have forgotten to update the changelog!
|
Codecov Report
@@ Coverage Diff @@
## master #319 +/- ##
=======================================
Coverage 99.79% 99.79%
=======================================
Files 40 40
Lines 3929 3929
=======================================
Hits 3921 3921
Misses 8 8
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mlxd for putting this together! I may suggest to add pyver
in a separate yml file and re-use it with wheels .yml instead of defining it in all of them. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one single comment.
Another potential issue I found is that |
I think I was relying on this to merge all wheels into a single Zip, as twine uploads accepts a Zip of all wheels as a single pass, and each wheel will be guaranteed a unique name from the builder and naming semantics. But you are correct that this is something we may want to update for how it is handled. I think we can handle this separately as they seem to still be debating the behaviour in the action, and it looks like nothing will change on this before the next release. Thoughts? |
👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to approve this!
Thanks for the reviews all. |
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
tests
directory!All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs
.Ensure that the test suite passes, by running
make test
.Add a new entry to the
.github/CHANGELOG.md
file, summarizing thechange, and including a link back to the PR.
Ensure that code is properly formatted by running
make format
.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context: This PR removes the need for intermediate Python version tests between the supported extrema versions (currently 3.7-3.10) for PRs. The full builder suite is still run on merge to master, and release. We also update to MacOS11 in tandem.
Description of the Change: See above.
Benefits: Reduced PR resource requirements and overhead for running CI checks.
Possible Drawbacks: Minimal chance of intermediate Python version issues that are reported on merge to master.
Related GitHub Issues: