Add IsingXY #303

multiphaseCFD · 2022-06-14T13:44:43Z

Before submitting

Please complete the following checklist when submitting a PR:

All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
tests directory!
All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running make docs.
[ x] Ensure that the test suite passes, by running make test.
Add a new entry to the .github/CHANGELOG.md file, summarizing the
change, and including a link back to the PR.
Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.

Context:

Description of the Change:

Benefits:

Possible Drawbacks:

Macbook air M1 doesn't support large memory allocation in the tests

Related GitHub Issues:

github-actions · 2022-06-14T13:45:11Z

Hello. You may have forgotten to update the changelog!
Please edit .github/CHANGELOG.md with:

A one-to-two sentence description of the change. You may include a small working example for new features.
A link back to this PR.
Your name (or GitHub username) in the contributors section.

chaeyeunpark · 2022-06-14T13:58:17Z

Yes, there is an issue due to my poorly written workflow 😞 . You can just push an empty commit by

git commit --allow-empty -m 'Trigger CI'
git push

to rerun all workflows.

multiphaseCFD · 2022-06-14T14:05:39Z

Yes, there is an issue due to my poorly written workflow 😞 . You can just push an empty commit by
git commit --allow-empty -m 'Trigger CI'
git push
to rerun all workflows.

Done!

…ennylane-lightning into origin/add_isingxy

github-actions · 2022-06-14T15:36:34Z

Test Report (C++) on Ubuntu

          1 files ±  0           1 suites ±0 2s ⏱️ -1s
      912 tests +28       912 ✔️ +28 0 💤 ±0 0 ❌ ±0
229 195 runs +49 229 195 ✔️ +49 0 💤 ±0 0 ❌ ±0

Results for commit 8d9f709. ± Comparison against base commit e4bca20.

♻️ This comment has been updated with latest results.

codecov · 2022-06-14T15:45:15Z

Codecov Report

Merging #303 (8d9f709) into master (e4bca20) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #303   +/-   ##
=======================================
  Coverage   99.44%   99.45%           
=======================================
  Files          36       36           
  Lines        3605     3656   +51     
=======================================
+ Hits         3585     3636   +51     
  Misses         20       20

Impacted Files	Coverage Δ
...ennylane_lightning/src/gates/OpToMemberFuncPtr.hpp	`100.00% <ø> (ø)`
pennylane_lightning/_version.py	`100.00% <100.00%> (ø)`
...ng/src/gates/cpu_kernels/GateImplementationsLM.hpp	`100.00% <100.00%> (ø)`
...ng/src/gates/cpu_kernels/GateImplementationsPI.hpp	`100.00% <100.00%> (ø)`
pennylane_lightning/src/simulator/KernelMap.cpp	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4bca20...8d9f709. Read the comment docs.

chaeyeunpark · 2022-06-14T15:52:08Z

It seems like all tests pass besides Format (C++). After installing clang-format-12, you may just run make format in the root of source code directory.

multiphaseCFD · 2022-06-14T16:09:38Z

clang-format-12

Thanks! I failed to install clang-format on M1 and I tried to use black to make better format. Will try to install clang-format again and get back to you.

AmintorDusko · 2022-06-14T17:02:47Z

Hi @multiphaseCFD. I think you need to add .DS_store to the .gitignore file.
You may need to remove the files already committed.

chaeyeunpark

I have one specific question here. I also would like to ask you benchmark two implementations. You can run make gbenchmark and follow the instruction in https://github.com/PennyLaneAI/pennylane-lightning/blob/master/pennylane_lightning/src/benchmarks/README.md#benchmarksbench_kernels. Note that you can also filter the benchmarks to run. For more information, you may run ./BuildGBench/benchmarks/bench_kernels --help

chaeyeunpark · 2022-06-14T17:12:43Z

pennylane_lightning/src/tests/Test_GateImplementations_Param.cpp

+            ComplexPrecisionT{0.089653238654, 0.221581339836},
+            ComplexPrecisionT{0.217892318964, 0.291261285543},
+            ComplexPrecisionT{0.292993247509, 0.186570793390},
+        };


Is this the result from default.qubit?

Is this the result from default.qubit?

Yes

AmintorDusko

Nice work, so far!

multiphaseCFD · 2022-06-14T18:38:09Z

I have one specific question here. I also would like to ask you benchmark two implementations. You can run make gbenchmark and follow the instruction in https://github.com/PennyLaneAI/pennylane-lightning/blob/master/pennylane_lightning/src/benchmarks/README.md#benchmarksbench_kernels. Note that you can also filter the benchmarks to run. For more information, you may run ./BuildGBench/benchmarks/bench_kernels --help

chaeyeunpark · 2022-06-14T18:45:18Z

Thanks @multiphaseCFD for a nice job! Still, I think you may need to implement a generator for a backward path. When a gate is a one-paramter Lie group, given by $e^{-iG\theta}$, we call $G$ as the generator. Could you try this too? Please let me know when there is any question.

mlxd

Nice work @multiphaseCFD !
I'll approve. Once the others approve too we can merge this in.
Also, agreed with @chaeyeunpark for the backwards pass generator,

multiphaseCFD · 2022-06-14T18:56:25Z

Thanks @multiphaseCFD for a nice job! Still, I think you may need to implement a generator for a backward path. When a gate is a one-paramter Lie group, given by e−iGθ, we call G as the generator. Could you try this too? Please let me know when there is any question.

Sure! I will try this after I finalized current PR. As @mlxd told me, what I have to do for this PR is just implementing IsingXY gate. Is it fine with you @chaeyeunpark ?

multiphaseCFD · 2022-06-14T18:56:41Z

Nice work @multiphaseCFD ! I'll approve. Once the others approve too we can merge this in. Also, agreed with @chaeyeunpark for the backwards pass generator,

Thanks @mlxd !

chaeyeunpark · 2022-06-14T18:57:52Z

Sure! Looking forward to seeing the generator for IsingXY in a subsequent PR. I am also gonna approve this.

AmintorDusko

Nice work! Thanks for that!

multiphaseCFD · 2022-06-14T19:11:12Z

Sure! Looking forward to seeing the generator for IsingXY in a subsequent PR. I am also gonna approve this.

Sure! I've put it into my tasks.

.DS_Store deleted

multiphaseCFD · 2022-06-14T19:29:17Z

Nice work! Thanks for that!

Thanks!

Add IsingXY

e0b4975

Auto update version

c0dfaf7

Trigger CI

9913ca2

multiphaseCFD added 7 commits June 14, 2022 11:00

Trigger CI

edf3662

Trigger CI

b7f513f

Trigger CI

819fee1

Trigger CI

a2a70d8

Trigger CI

d9d3a69

Merge branch 'origin/add_isingxy' of https://github.com/PennyLaneAI/p…

edb2663

…ennylane-lightning into origin/add_isingxy

Trigger CI

96b8477

multiphaseCFD added 2 commits June 14, 2022 12:15

Trigger CI

c318004

make format

7ca37a0

chaeyeunpark reviewed Jun 14, 2022

View reviewed changes

make format

c0e034d

AmintorDusko reviewed Jun 14, 2022

View reviewed changes

mlxd approved these changes Jun 14, 2022

View reviewed changes

chaeyeunpark approved these changes Jun 14, 2022

View reviewed changes

AmintorDusko approved these changes Jun 14, 2022

View reviewed changes

multiphaseCFD added 4 commits June 14, 2022 15:21

Delete .DS_Store

be294fc

.DS_Store deleted

Delete .DS_Store

0581e8c

Delete .DS_store

ff42ee6

Delete .DS_Store

54fe738

multiphaseCFD added 2 commits June 14, 2022 15:34

Delete .DS_Store

1d24bb2

Trigger CI

8d9f709

multiphaseCFD merged commit a6f4c99 into master Jun 14, 2022

multiphaseCFD deleted the origin/add_isingxy branch June 14, 2022 20:13

mlxd mentioned this pull request Jun 15, 2022

Handle IsingXY gate #300

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add IsingXY #303

Add IsingXY #303

multiphaseCFD commented Jun 14, 2022

github-actions bot commented Jun 14, 2022

chaeyeunpark commented Jun 14, 2022

multiphaseCFD commented Jun 14, 2022

github-actions bot commented Jun 14, 2022 •

edited

Loading

codecov bot commented Jun 14, 2022 •

edited

Loading

chaeyeunpark commented Jun 14, 2022

multiphaseCFD commented Jun 14, 2022

AmintorDusko commented Jun 14, 2022 •

edited

Loading

chaeyeunpark left a comment

chaeyeunpark Jun 14, 2022

multiphaseCFD Jun 14, 2022

AmintorDusko left a comment

multiphaseCFD commented Jun 14, 2022

chaeyeunpark commented Jun 14, 2022

mlxd left a comment •

edited

Loading

multiphaseCFD commented Jun 14, 2022

multiphaseCFD commented Jun 14, 2022

chaeyeunpark commented Jun 14, 2022

AmintorDusko left a comment

multiphaseCFD commented Jun 14, 2022

multiphaseCFD commented Jun 14, 2022

Add IsingXY #303

Add IsingXY #303

Conversation

multiphaseCFD commented Jun 14, 2022

Before submitting

github-actions bot commented Jun 14, 2022

chaeyeunpark commented Jun 14, 2022

multiphaseCFD commented Jun 14, 2022

github-actions bot commented Jun 14, 2022 • edited Loading

Test Report (C++) on Ubuntu

codecov bot commented Jun 14, 2022 • edited Loading

Codecov Report

chaeyeunpark commented Jun 14, 2022

multiphaseCFD commented Jun 14, 2022

AmintorDusko commented Jun 14, 2022 • edited Loading

chaeyeunpark left a comment

Choose a reason for hiding this comment

chaeyeunpark Jun 14, 2022

Choose a reason for hiding this comment

multiphaseCFD Jun 14, 2022

Choose a reason for hiding this comment

AmintorDusko left a comment

Choose a reason for hiding this comment

multiphaseCFD commented Jun 14, 2022

chaeyeunpark commented Jun 14, 2022

mlxd left a comment • edited Loading

Choose a reason for hiding this comment

multiphaseCFD commented Jun 14, 2022

multiphaseCFD commented Jun 14, 2022

chaeyeunpark commented Jun 14, 2022

AmintorDusko left a comment

Choose a reason for hiding this comment

multiphaseCFD commented Jun 14, 2022

multiphaseCFD commented Jun 14, 2022

github-actions bot commented Jun 14, 2022 •

edited

Loading

codecov bot commented Jun 14, 2022 •

edited

Loading

AmintorDusko commented Jun 14, 2022 •

edited

Loading

mlxd left a comment •

edited

Loading