-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the issue with using available clang-format version in format #288
Conversation
Hello. You may have forgotten to update the changelog!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work @maliasadi
I re-enabled the failed tests. Once They pass I'll approve
Codecov Report
@@ Coverage Diff @@
## master #288 +/- ##
=======================================
Coverage 98.86% 98.86%
=======================================
Files 27 27
Lines 2913 2913
=======================================
Hits 2880 2880
Misses 33 33
Continue to review full report at Codecov.
|
@maliasadi Thanks for the change (and increase the readability of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
make format
(andmake format-cpp
) now accepts the version number in caseclang-format
is not installed or not satisfying the default version -- that is currently12
. This update avoids inconsistencies between different clang-format aliases and eases trying different versions when needed.