-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implements native support for Sparse Hamiltonians expval() calculation with Kokkos #283
Conversation
Hello. You may have forgotten to update the changelog!
|
Codecov Report
@@ Coverage Diff @@
## master #283 +/- ##
==========================================
+ Coverage 99.24% 99.44% +0.19%
==========================================
Files 29 30 +1
Lines 3330 3410 +80
==========================================
+ Hits 3305 3391 +86
+ Misses 25 19 -6
Continue to review full report at Codecov.
|
…ane-lightning into feature/Kokkos-sparse
Hi @AmintorDusko, I think Kokkos does not support MSVC. We may need to try clang-cl instead... I will ping you on slack. |
Yes. Its looks like it! Thank you very much @chaeyeunpark! |
…ane-lightning into feature/Kokkos-sparse
…g-tidy inspection
…ane-lightning into feature/Kokkos-sparse
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Amintor, I have a few more comments/questions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work on this Amintor! One last thing we need is to update the license statement at the end of the Lightning README to indicate we are using Kokkos under the BSD license (see Jet's statement here for an example).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @AmintorDusko. great job! 💯 Sorry for this late review; I was thinking this one is still work-in-progress 🙁 As this one already merged and you also merged the follow-up PR (#296). I'll go with a few general comments to be applied for later...
Context:
This PR implements native support for sparse Hamiltonians expval calculation.
Sparse operations are offloaded to Kokkos.
Description of the Change:
Add native support for the calculation of sparse Hamiltonians' expectation values.
Benefits:
Performant calculation with Pennylane-Lightning
Possible Drawbacks:
Not that I'm aware of.
Related GitHub Issues:
Not that I'm aware of.