Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test measures #280

Merged
merged 1 commit into from
Apr 18, 2022
Merged

Fix test measures #280

merged 1 commit into from
Apr 18, 2022

Conversation

chaeyeunpark
Copy link
Contributor

@chaeyeunpark chaeyeunpark commented Apr 18, 2022 •
edited by antalszava
Loading

After recent changes in PL, qml.probs does not accept wires=None anymore.

@github-actions
Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit .github/CHANGELOG.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 18, 2022 •
edited
Loading

Test Report (C++) on Ubuntu

           1 files  ±0             1 suites  ±0   0s ⏱️ ±0s
       711 tests ±0         711 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
228 386 runs  ±0  228 386 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit f7cfb53. ± Comparison against base commit 66967fa.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Apr 18, 2022

Codecov Report

Merging #280 (f7cfb53) into v0.23_rc0 (66967fa) will increase coverage by 10.88%.
The diff coverage is n/a.

@@              Coverage Diff               @@
##           v0.23_rc0     #280       +/-   ##
==============================================
+ Coverage      87.98%   98.86%   +10.88%     
==============================================
  Files             27       27               
  Lines           2913     2913               
==============================================
+ Hits            2563     2880      +317     
+ Misses           350       33      -317
Impacted Files Coverage Δ
pennylane_lightning/_serialize.py 100.00% <0.00%> (+81.92%) ⬆️
pennylane_lightning/lightning_qubit.py 100.00% <0.00%> (+84.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66967fa...f7cfb53. Read the comment docs.

antalszava
antalszava approved these changes Apr 18, 2022
View reviewed changes
Copy link
Contributor

@antalszava antalszava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you for catching this! 🎉

@chaeyeunpark chaeyeunpark merged commit 31a1386 into v0.23_rc0 Apr 18, 2022
@chaeyeunpark chaeyeunpark deleted the fix_test_measure branch April 18, 2022 23:39
@chaeyeunpark chaeyeunpark mentioned this pull request Apr 21, 2022
Closed
chaeyeunpark added a commit that referenced this pull request Apr 26, 2022
@chaeyeunpark @mlxd @AmintorDusko
Apply updates from v0.23.0 to master (#286)
9b585ec 
* Create RC0

* Fix test measures (#280)

* Update changelog

* Add some missing PRs to Changelog

* Update catch2 version to fix compilation issues with non const linux headers

* Update qml.probs in tests

* Update .github/CHANGELOG.md

Co-authored-by: Amintor Dusko <[email protected]>

* Revert wires=[] case

* Drop rc tag from version

* Add missing contributor

* Fix wheel upload names

Co-authored-by: Lee J. O'Riordan <[email protected]>
Co-authored-by: Amintor Dusko <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maliasadi maliasadi maliasadi left review comments

@antalszava antalszava antalszava approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chaeyeunpark @maliasadi @antalszava