Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip over identity ops in "lightning.qubit" #268

Merged
merged 10 commits into from
Mar 22, 2022
Merged

Conversation

maliasadi
Copy link
Member

Context:
Fix issue #267.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 22, 2022

Test Report (C++) on Ubuntu

           1 files  ±0             1 suites  ±0   0s ⏱️ ±0s
       660 tests ±0         660 ✔️ ±0  0 💤 ±0  0 ±0 
228 174 runs  ±0  228 174 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit be6b795. ± Comparison against base commit 4c14421.

♻️ This comment has been updated with latest results.

@maliasadi maliasadi requested review from mlxd and albi3ro March 22, 2022 04:07
@codecov
Copy link

codecov bot commented Mar 22, 2022

Codecov Report

Merging #268 (1b97f31) into master (4c14421) will decrease coverage by 0.26%.
The diff coverage is 85.71%.

❗ Current head 1b97f31 differs from pull request most recent head be6b795. Consider uploading reports for the commit be6b795 to get more accurate results

@@             Coverage Diff             @@
##            master     #268      +/-   ##
===========================================
- Coverage   100.00%   99.73%   -0.27%     
===========================================
  Files            4        4              
  Lines          379      383       +4     
===========================================
+ Hits           379      382       +3     
- Misses           0        1       +1     
Impacted Files Coverage Δ
pennylane_lightning/lightning_qubit.py 99.66% <83.33%> (-0.34%) ⬇️
pennylane_lightning/_version.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c14421...be6b795. Read the comment docs.

Copy link
Member

@mlxd mlxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one @maliasadi
Just left one comment, but happy to go with whatever you think works.

@maliasadi maliasadi merged commit ef2d832 into master Mar 22, 2022
@maliasadi maliasadi deleted the device-ignore-identity branch March 22, 2022 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants