Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better kernel dispatch and add custom _asarray #245

Closed
wants to merge 116 commits into from
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
116 commits
Select commit Hold shift + click to select a range
9a6722c
Managed to CPU
chaeyeunpark Feb 27, 2022
9398a0a
StateVector architecture refatored; pass tests
chaeyeunpark Feb 27, 2022
ff394e5
Export to python
chaeyeunpark Mar 1, 2022
12299f6
Fix examples
chaeyeunpark Mar 2, 2022
a0df568
Update benchmark
chaeyeunpark Mar 2, 2022
d0265b3
Update CMake
chaeyeunpark Mar 2, 2022
d4b92d1
Fix for tidy
chaeyeunpark Mar 2, 2022
aa8f312
Fix for codefac
chaeyeunpark Mar 2, 2022
717c068
Update for Codefactor
chaeyeunpark Mar 2, 2022
fc5dce9
Fix version script
chaeyeunpark Mar 2, 2022
c219a5c
More fix for codecov
chaeyeunpark Mar 2, 2022
c882648
tidy test
chaeyeunpark Mar 2, 2022
6a8c179
Fix for clang
chaeyeunpark Mar 2, 2022
5bf1855
Merge remote-tracking branch 'origin/master' into better_kernel_dispatch
chaeyeunpark Mar 2, 2022
338cf53
Auto update version
chaeyeunpark Mar 2, 2022
13ed29e
More fix for appleclang
chaeyeunpark Mar 2, 2022
0a515a2
Merge branch 'better_kernel_dispatch' of github.com:PennyLaneAI/penny…
chaeyeunpark Mar 2, 2022
09b471e
Fix aligned memory
chaeyeunpark Mar 2, 2022
30c7d42
Clean-up, fix ld warnings for appleclang
chaeyeunpark Mar 2, 2022
f33876e
Fix
chaeyeunpark Mar 2, 2022
af6387b
Fix memory allocate mechanism; Fix some tests for MSVX
chaeyeunpark Mar 2, 2022
5adac41
Fix a UB
chaeyeunpark Mar 2, 2022
345c226
Fix some bugs
chaeyeunpark Mar 3, 2022
7881d6f
black
chaeyeunpark Mar 3, 2022
f6866bb
Fix for coverage
chaeyeunpark Mar 3, 2022
31d6585
Update for -Wpedantic
chaeyeunpark Mar 3, 2022
857a831
Some fix for tidy
chaeyeunpark Mar 3, 2022
838b691
Fix
chaeyeunpark Mar 3, 2022
c096258
Add omp for clang
chaeyeunpark Mar 3, 2022
73a812b
Specify version
chaeyeunpark Mar 3, 2022
41adfe0
Fix
chaeyeunpark Mar 3, 2022
5dd0919
Trigger
chaeyeunpark Mar 3, 2022
63b52c7
Fix
chaeyeunpark Mar 3, 2022
1102ad0
KernelMap refactor
chaeyeunpark Mar 3, 2022
e51ffb5
Fix for mac
chaeyeunpark Mar 3, 2022
0c991d4
Simplified a bit
chaeyeunpark Mar 4, 2022
4b6f82d
Add runtime/compiletime info
chaeyeunpark Mar 6, 2022
fc54bcb
Fix for windows
chaeyeunpark Mar 6, 2022
ad5c60a
Fix
chaeyeunpark Mar 6, 2022
39766bf
Fix for MSVC
chaeyeunpark Mar 6, 2022
34ee658
Fix benchmark plot
chaeyeunpark Mar 6, 2022
e34ca57
Fix for MSVC
chaeyeunpark Mar 6, 2022
b7f1e6e
Rollback makefile
chaeyeunpark Mar 6, 2022
f05118e
Fix snapshot
chaeyeunpark Mar 6, 2022
4c988b3
Merge remote-tracking branch 'origin/master' into better_kernel_dispatch
chaeyeunpark Mar 8, 2022
4bd9598
Auto update version
chaeyeunpark Mar 8, 2022
765c684
Remove snapshot check in apply
chaeyeunpark Mar 8, 2022
eb10ed2
Merge branch 'better_kernel_dispatch' of github.com:PennyLaneAI/penny…
chaeyeunpark Mar 8, 2022
1c2c50f
Update tests
chaeyeunpark Mar 8, 2022
c7b0334
Merge remote-tracking branch 'origin/master' into better_kernel_dispatch
chaeyeunpark Mar 9, 2022
b020701
Fix some functions; Documents added
chaeyeunpark Mar 9, 2022
1ee00b3
Merge remote-tracking branch 'origin/master' into better_kernel_dispatch
chaeyeunpark Mar 9, 2022
cef939c
Auto update version
chaeyeunpark Mar 9, 2022
ac8ef31
Trigger CI
chaeyeunpark Mar 9, 2022
991f85b
Merge branch 'better_kernel_dispatch' of github.com:PennyLaneAI/penny…
chaeyeunpark Mar 9, 2022
bbd5840
Fix namespace
chaeyeunpark Mar 9, 2022
13009de
Fix namespace
chaeyeunpark Mar 9, 2022
df068a8
Fix some docs
chaeyeunpark Mar 9, 2022
a6c629c
Fix for tidy
chaeyeunpark Mar 9, 2022
b6569dc
Update Util; Update doc
chaeyeunpark Mar 10, 2022
1f9590b
Add tests
chaeyeunpark Mar 10, 2022
66ceab5
Add runtime/compile info in binary
chaeyeunpark Mar 10, 2022
d237ceb
Auto update version
chaeyeunpark Mar 10, 2022
386edb6
Fix for non-biary
chaeyeunpark Mar 10, 2022
db00391
Merge branch 'pre_better_kernel_dispatch' of github.com:PennyLaneAI/p…
chaeyeunpark Mar 10, 2022
cd9027f
Format
chaeyeunpark Mar 10, 2022
da3d9ec
Update tidy
chaeyeunpark Mar 10, 2022
6f7d770
Fix for tidy
chaeyeunpark Mar 10, 2022
16df125
Trigger CI
chaeyeunpark Mar 10, 2022
6908f20
Futher update in tests
chaeyeunpark Mar 10, 2022
fd2c3f6
Apply suggestions from code review
chaeyeunpark Mar 14, 2022
de62ece
Update pennylane_lightning/src/bindings/Bindings.cpp
chaeyeunpark Mar 14, 2022
6507b59
Fix PLApprox
chaeyeunpark Mar 14, 2022
1c450d2
Update pennylane_lightning/src/tests/CreateAllWires.cpp
chaeyeunpark Mar 14, 2022
131c626
Fix createAllWires; Add NVCC/NVHPC compiler info
chaeyeunpark Mar 14, 2022
02b5e33
Fix
chaeyeunpark Mar 14, 2022
351841c
Add test for squaredNorm
chaeyeunpark Mar 14, 2022
92f0ee6
Add correct arg
chaeyeunpark Mar 15, 2022
cbe36ac
Slightly refactor static_lookup
chaeyeunpark Mar 15, 2022
26a508d
Rename AMD64 to x86_64
chaeyeunpark Mar 15, 2022
8cbef26
Add docstring
chaeyeunpark Mar 15, 2022
3ea7b49
add docstring
chaeyeunpark Mar 15, 2022
d259198
Merge remote-tracking branch 'origin/master' into pre_better_kernel_d…
chaeyeunpark Mar 15, 2022
cb3256e
Auto update version
chaeyeunpark Mar 15, 2022
4be5ac6
Format
chaeyeunpark Mar 15, 2022
ebbcf68
Small fix
chaeyeunpark Mar 16, 2022
97bc9b9
Auto update version
chaeyeunpark Mar 16, 2022
f9ec2af
Some more fix
chaeyeunpark Mar 16, 2022
34f5754
Merge remote-tracking branch 'origin/master' into pre_better_kernel_d…
chaeyeunpark Mar 16, 2022
865557e
Trigger CI
chaeyeunpark Mar 16, 2022
b5fb3ae
Merge remote-tracking branch 'origin/master' into pre_better_kernel_d…
chaeyeunpark Mar 17, 2022
86531d5
Auto update version
chaeyeunpark Mar 17, 2022
466b8ad
Merge remote-tracking branch 'origin/master' into pre_better_kernel_d…
chaeyeunpark Mar 17, 2022
cf654a7
Auto update version
chaeyeunpark Mar 17, 2022
b341f8c
Trigger CI
chaeyeunpark Mar 17, 2022
ac985c6
Trigger CI
chaeyeunpark Mar 17, 2022
00f4dc7
Trigger CI
chaeyeunpark Mar 18, 2022
a46a41f
Auto update version
chaeyeunpark Mar 18, 2022
7970643
Merge remote-tracking branch 'origin/master' into pre_better_kernel_d…
chaeyeunpark Mar 18, 2022
de3457e
Merge branch 'pre_better_kernel_dispatch' of github.com:PennyLaneAI/p…
chaeyeunpark Mar 18, 2022
b5b043a
Merge remote-tracking branch 'origin/master' into pre_better_kernel_d…
chaeyeunpark Mar 19, 2022
3bcba89
Fix doc
chaeyeunpark Mar 19, 2022
d0c6920
Merge branch 'pre_better_kernel_dispatch' into merging_better_kernel_…
chaeyeunpark Mar 20, 2022
4cd65a6
Merge remote-tracking branch 'origin/master' into better_kernel_dispatch
chaeyeunpark Mar 22, 2022
d358a3c
Auto update version
chaeyeunpark Mar 22, 2022
1ffa7c4
Merge branch 'master' into better_kernel_dispatch
chaeyeunpark Mar 22, 2022
8024358
Format
chaeyeunpark Mar 23, 2022
190f088
Merge branch 'better_kernel_dispatch' of github.com:PennyLaneAI/penny…
chaeyeunpark Mar 23, 2022
cf8281c
Merge branch 'master' into better_kernel_dispatch
chaeyeunpark Mar 23, 2022
04897a0
Auto update version
chaeyeunpark Mar 23, 2022
9528481
Trigger CI
chaeyeunpark Mar 23, 2022
11b3aa0
Merge remote-tracking branch 'origin/master' into better_kernel_dispatch
chaeyeunpark Mar 28, 2022
3c94391
Merge remote-tracking branch 'origin/master' into better_kernel_dispatch
chaeyeunpark May 7, 2022
6e35950
Auto update version
chaeyeunpark May 7, 2022
d20339c
Remove files
chaeyeunpark May 7, 2022
0eced01
Fix
chaeyeunpark May 7, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update for Codefactor
  • Loading branch information
chaeyeunpark committed Mar 2, 2022
commit 717c0683c92208fc1a760a3d320e898998c5e407
1 change: 0 additions & 1 deletion pennylane_lightning/src/bindings/Bindings.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,6 @@ void deallocateArray(void *ptr) { std::free(ptr); }
* for capsule usage.
*/
auto allocateAlignedArray(size_t size, pybind11::dtype dt) -> pybind11::array {

auto memory_model = bestCPUMemoryModel();

if (dt.is(pybind11::dtype::of<float>())) {
Expand Down
1 change: 0 additions & 1 deletion pennylane_lightning/src/examples/benchmark_generator.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,6 @@ auto generateGeneratorSequence(RandomEngine &re,
std::uniform_int_distribution<size_t> inverse_dist(0, 1);

for (uint32_t k = 0; k < num_reps; k++) {

bool inverse = static_cast<bool>(inverse_dist(re));
auto wires = generateNeighboringWires(re, num_qubits, num_wires);

Expand Down
12 changes: 4 additions & 8 deletions pennylane_lightning/src/examples/run_benchmark.py
Original file line number Diff line number Diff line change
Expand Up @@ -84,14 +84,12 @@ def command(self, num_qubits):
def external_info(self):
if self.num_wires:
return {"num_wires": self.num_wires}
else:
return None
return None

def filename(self):
if self.num_wires:
return f"{self.operation}_{self.kernel}_{self.num_wires}.json"
else:
return f"{self.operation}_{self.kernel}.json"
return f"{self.operation}_{self.kernel}.json"


class GeneratorBenchmarkRunner(BenchmarkRunner):
Expand All @@ -108,14 +106,12 @@ def command(self, num_qubits):
def external_info(self):
if self.num_wires:
return {"num_wires": self.num_wires}
else:
return None
return None

def filename(self):
if self.num_wires:
return f"{self.operation}_{self.kernel}_{self.num_wires}.json"
else:
return f"{self.operation}_{self.kernel}.json"
return f"{self.operation}_{self.kernel}.json"


if __name__ == "__main__":
Expand Down
44 changes: 0 additions & 44 deletions pennylane_lightning/src/examples/run_benchmark.sh

This file was deleted.

1 change: 0 additions & 1 deletion pennylane_lightning/src/examples/test.sh

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,6 @@ class GateImplementationsLM : public PauliGenerator<GateImplementationsLM> {

if (inverse) {
for (size_t k = 0; k < Util::exp2(num_qubits); k += dim) {

for (size_t inner_idx = 0; inner_idx < dim; inner_idx++) {
size_t idx = k | inner_idx;
size_t n_wires = wires.size();
Expand All @@ -285,7 +284,6 @@ class GateImplementationsLM : public PauliGenerator<GateImplementationsLM> {
}
} else {
for (size_t k = 0; k < Util::exp2(num_qubits); k += dim) {

for (size_t inner_idx = 0; inner_idx < dim; inner_idx++) {
size_t idx = k | inner_idx;
size_t n_wires = wires.size();
Expand Down
2 changes: 0 additions & 2 deletions pennylane_lightning/src/simulator/StateVectorManagedCPU.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ class StateVectorManagedCPU
size_t num_qubits, Threading threading = bestThreading(),
CPUMemoryModel memory_model = bestCPUMemoryModel())
: BaseType{num_qubits, threading, memory_model} {

size_t length = BaseType::getLength();
data_ = allocateMemory<ComplexPrecisionT>(memory_model, length);
std::fill(data_.get(), data_.get() + length,
Expand All @@ -61,7 +60,6 @@ class StateVectorManagedCPU
const StateVectorCPU<PrecisionT, OtherDerived> &other)
: BaseType(other.getNumQubits(), other.threading(),
other.memoryModel()) {

size_t length = BaseType::getLength();
data_ = allocateMemory<ComplexPrecisionT>(other.memoryModel(), length);

Expand Down
1 change: 0 additions & 1 deletion pennylane_lightning/src/tests/CreateAllWires.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
namespace Pennylane {
auto crateAllWires(size_t n_qubits, Gates::GateOperation gate_op, bool order)
-> std::vector<std::vector<size_t>> {

if (Util::array_has_elt(Gates::Constant::multi_qubit_gates, gate_op)) {
// make all possible 2^N permutations
std::vector<std::vector<size_t>> res;
Expand Down
1 change: 0 additions & 1 deletion pennylane_lightning/src/tests/Test_Internal.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,6 @@ size_t permSize(size_t n, size_t r) {
* @brief Test create all wires
*/
TEST_CASE("createAllWires", "[Test_Internal]") {

SECTION("order = false") {
const std::vector<std::pair<size_t, size_t>> test_pairs{
{4, 2}, {8, 3}, {12, 1}, {12, 2}, {12, 3}, {12, 4}, {12, 5},
Expand Down