Include C++ source files in binary wheels #225
Conversation
|
Hello. You may have forgotten to update the changelog!
|
Codecov Report
@@ Coverage Diff @@
## master #225 +/- ##
=======================================
Coverage 99.71% 99.71%
=======================================
Files 4 4
Lines 351 351
=======================================
Hits 350 350
Misses 1 1 Continue to review full report at Codecov.
|
| @@ -118,7 +108,8 @@ def build_extension(self, ext: CMakeExtension): | |||
| "url": "https://github.com/XanaduAI/pennylane-lightning", | |||
| "license": "Apache License 2.0", | |||
| "packages": find_packages(where="."), | |||
| "package_data": {"pennylane_lightning": ["src/*"]}, | |||
| "package_data": {"pennylane_lightning": ["src/*", "src/**/*"]}, | |||
There was a problem hiding this comment.
Hi @mlxd, I just change this line. All other changes are from black. You can check wheels here: https://github.com/PennyLaneAI/pennylane-lightning/actions/runs/1796752045. If it looks good, I will revert workflow file and merge.
There was a problem hiding this comment.
Looks good @chaeyeunpark
I think since we can use this for the release, it counts as a bugfix so we can merge directly into the v0.21.0_rc0 branch
* Include C++ source files in binary wheels
* Update changelog and version * Update CHANGELOG * Add lightning v21 performance gains * Add lightning performance comparison with previous release * Update figure resolution * Update changelog data * Added example bm for latest lightning release * Include C++ source files in binary wheels (#225) * Include C++ source files in binary wheels * Auto update version * Auto update version * Auto update version Co-authored-by: Ali Asadi <[email protected]> Co-authored-by: Chae-Yeun Park <[email protected]>
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
testsdirectory!All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs.Ensure that the test suite passes, by running
make test.Add a new entry to the
.github/CHANGELOG.mdfile, summarizing thechange, and including a link back to the PR.
Ensure that code is properly formatted by running
make format.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context: After #176, binary wheels do not include C++ source files. This PR fixes it.
Description of the Change:
Benefits:
Possible Drawbacks:
Related GitHub Issues: