Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept gate lists in benchmarking #199

Merged
merged 10 commits into from
Dec 20, 2021
Merged

Conversation

chaeyeunpark
Copy link
Contributor

@chaeyeunpark chaeyeunpark commented Dec 16, 2021

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    tests directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the .github/CHANGELOG.md file, summarizing the
    change, and including a link back to the PR.

  • Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context: As a step to add an alternative implementation of kernel, it is good to have a benchmark code testing a given list of gates.

Description of the Change: Examples submodule is now under the main cmake; Benchmark code for a given list of gates added.

Benefits: We can now benchmark some gate operations we give. E.g. we can now

$ ./examples/gate_benchmark_oplist 1000 10 [PauliX, CNOT] # benchmark only PauliX and CNOT
$ LOG=1 ./examples/gate_benchmark_oplist 1000 10 [PauliX, CNOT] 2> gates.log # Same as above but log generated random gates sequence

Possible Drawbacks: I am not aware of any drawbacks.

Related GitHub Issues:

@github-actions
Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit .github/CHANGELOG.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@codecov
Copy link

codecov bot commented Dec 16, 2021

Codecov Report

Merging #199 (1b9efb3) into master (ab533a0) will not change coverage.
The diff coverage is n/a.

❗ Current head 1b9efb3 differs from pull request most recent head 30865ec. Consider uploading reports for the commit 30865ec to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #199   +/-   ##
=======================================
  Coverage   99.64%   99.64%           
=======================================
  Files           4        4           
  Lines         278      278           
=======================================
  Hits          277      277           
  Misses          1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab533a0...30865ec. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 16, 2021

Test Report (C++) on Ubuntu

       1 files  ±0         1 suites  ±0   0s ⏱️ ±0s
   378 tests ±0     378 ✔️ ±0  0 💤 ±0  0 ±0 
2 233 runs  ±0  2 233 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 30865ec. ± Comparison against base commit ab533a0.

♻️ This comment has been updated with latest results.

@chaeyeunpark chaeyeunpark marked this pull request as ready for review December 16, 2021 23:07
Copy link
Member

@mlxd mlxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @chaeyeunpark
I had some tiny comments, but happy to approve once they are answered.

@chaeyeunpark chaeyeunpark merged commit 978f739 into master Dec 20, 2021
@chaeyeunpark chaeyeunpark deleted the benchmark_accept_gates branch December 20, 2021 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants