-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accept gate lists in benchmarking #199
Conversation
Hello. You may have forgotten to update the changelog!
|
Codecov Report
@@ Coverage Diff @@
## master #199 +/- ##
=======================================
Coverage 99.64% 99.64%
=======================================
Files 4 4
Lines 278 278
=======================================
Hits 277 277
Misses 1 1 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @chaeyeunpark
I had some tiny comments, but happy to approve once they are answered.
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
tests
directory!All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs
.Ensure that the test suite passes, by running
make test
.Add a new entry to the
.github/CHANGELOG.md
file, summarizing thechange, and including a link back to the PR.
Ensure that code is properly formatted by running
make format
.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context: As a step to add an alternative implementation of kernel, it is good to have a benchmark code testing a given list of gates.
Description of the Change: Examples submodule is now under the main
cmake
; Benchmark code for a given list of gates added.Benefits: We can now benchmark some gate operations we give. E.g. we can now
Possible Drawbacks: I am not aware of any drawbacks.
Related GitHub Issues: