Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failed tests for the non-binary wheel #191

Merged
merged 3 commits into from
Dec 14, 2021

Conversation

maliasadi
Copy link
Member

No description provided.

@github-actions
Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit .github/CHANGELOG.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@codecov
Copy link

codecov bot commented Dec 14, 2021

Codecov Report

Merging #191 (fe82cf5) into master (c739f7b) will not change coverage.
The diff coverage is n/a.

❗ Current head fe82cf5 differs from pull request most recent head 5106db2. Consider uploading reports for the commit 5106db2 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #191   +/-   ##
=======================================
  Coverage   94.96%   94.96%           
=======================================
  Files           4        4           
  Lines         278      278           
=======================================
  Hits          264      264           
  Misses         14       14           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c739f7b...5106db2. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 14, 2021

Test Report (C++) on Ubuntu

       1 files  ±0         1 suites  ±0   0s ⏱️ ±0s
   368 tests ±0     368 ✔️ ±0  0 💤 ±0  0 ±0 
2 205 runs  ±0  2 205 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 5106db2. ± Comparison against base commit c739f7b.

♻️ This comment has been updated with latest results.

@maliasadi maliasadi requested a review from mlxd December 14, 2021 16:16
Copy link
Member

@mlxd mlxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @maliasadi

@maliasadi maliasadi merged commit 364cfe4 into master Dec 14, 2021
@maliasadi maliasadi deleted the lightning_fix_tests_non_binary_wheel branch December 14, 2021 18:16
@mlxd mlxd restored the lightning_fix_tests_non_binary_wheel branch December 15, 2021 10:07
@mlxd mlxd deleted the lightning_fix_tests_non_binary_wheel branch December 15, 2021 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants