Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gate Aggregate Performance Tests; Issue #158 #165

Merged
merged 44 commits into from
Dec 6, 2021

Conversation

isschoch
Copy link
Contributor

@isschoch isschoch commented Nov 5, 2021

Context:
Technical part of coding challenge for Xanadu residency program.
Description of the Change:
Added a new directory called "examples". In this directory one can benchmark the performance of the gates in Pennylane-Lightning with qubits ranging from 6 to 22 in steps of 2 by running the run_gate_benchmark.sh script.
Benefits:
Can be used to assess performance of gates in Pennylane-Lightning.
Possible Drawbacks:
Using gprof will give you a more nuanced overview.
Related GitHub Issues:
Issue #158

@mlxd
Copy link
Member

mlxd commented Nov 5, 2021

Thank for the submission @isschoch
We'll have a look and get back to you early next week!

@mlxd mlxd self-requested a review November 5, 2021 18:38
@codecov
Copy link

codecov bot commented Nov 5, 2021

Codecov Report

Merging #165 (ace3eca) into master (d1a4981) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #165   +/-   ##
=======================================
  Coverage   92.97%   92.97%           
=======================================
  Files           4        4           
  Lines         185      185           
=======================================
  Hits          172      172           
  Misses         13       13           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1a4981...ace3eca. Read the comment docs.

@mlxd
Copy link
Member

mlxd commented Nov 15, 2021

Hi @isschoch thanks again for the contribution. To finish off this work, I will ask for some small changes in your code review. There is no hurry here, so feel free to get back to it when suits you.

Copy link
Member

@mlxd mlxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on this. I have a few small comments to make below:

Copy link
Member

@mlxd mlxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work again! I have a few more small suggestions.

@mlxd
Copy link
Member

mlxd commented Dec 3, 2021

Hey @isschoch great job on this. I am happy to see it added to the repo.

The testing seems to be failing with the recent merge from master --- I think it should be fine to try adding an empty commit to trigger the CI with: git commit -m "Trigger CI" --alow-empty and I'll reapprove the runs.

@isschoch
Copy link
Contributor Author

isschoch commented Dec 6, 2021

@mlxd thank you for notifying me about the runs. Sorry for pushing the change so late, is it still early enough for the 0.20-dev release?

@mlxd
Copy link
Member

mlxd commented Dec 6, 2021

@mlxd thank you for notifying me about the runs. Sorry for pushing the change so late, is it still early enough for the 0.20-dev release?

All good --- I'll let the runs go, and if everything passes I'll merge immediately for 0.20. Good job again!

@mlxd mlxd merged commit 82c197b into PennyLaneAI:master Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants