-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gate Aggregate Performance Tests; Issue #158 #165
Conversation
Thank for the submission @isschoch |
Codecov Report
@@ Coverage Diff @@
## master #165 +/- ##
=======================================
Coverage 92.97% 92.97%
=======================================
Files 4 4
Lines 185 185
=======================================
Hits 172 172
Misses 13 13 Continue to review full report at Codecov.
|
Hi @isschoch thanks again for the contribution. To finish off this work, I will ask for some small changes in your code review. There is no hurry here, so feel free to get back to it when suits you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work on this. I have a few small comments to make below:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work again! I have a few more small suggestions.
Co-authored-by: Lee James O'Riordan <[email protected]>
Co-authored-by: Lee James O'Riordan <[email protected]>
Co-authored-by: Lee James O'Riordan <[email protected]>
Co-authored-by: Lee James O'Riordan <[email protected]>
Co-authored-by: Lee James O'Riordan <[email protected]>
Co-authored-by: Lee James O'Riordan <[email protected]>
Co-authored-by: Lee James O'Riordan <[email protected]>
Co-authored-by: Lee James O'Riordan <[email protected]>
Co-authored-by: Lee James O'Riordan <[email protected]>
Hey @isschoch great job on this. I am happy to see it added to the repo. The testing seems to be failing with the recent merge from master --- I think it should be fine to try adding an empty commit to trigger the CI with: |
@mlxd thank you for notifying me about the runs. Sorry for pushing the change so late, is it still early enough for the 0.20-dev release? |
All good --- I'll let the runs go, and if everything passes I'll merge immediately for |
Context:
Technical part of coding challenge for Xanadu residency program.
Description of the Change:
Added a new directory called "examples". In this directory one can benchmark the performance of the gates in Pennylane-Lightning with qubits ranging from 6 to 22 in steps of 2 by running the run_gate_benchmark.sh script.
Benefits:
Can be used to assess performance of gates in Pennylane-Lightning.
Possible Drawbacks:
Using gprof will give you a more nuanced overview.
Related GitHub Issues:
Issue #158