Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pre_release_version_bump.yml #160

Merged
merged 7 commits into from
Nov 3, 2021
Merged

Conversation

Jaybsoni
Copy link
Contributor

@Jaybsoni Jaybsoni commented Nov 2, 2021

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    tests directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the .github/CHANGELOG.md file, summarizing the
    change, and including a link back to the PR.

  • Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context:

Description of the Change:

Benefits:

Possible Drawbacks:

Related GitHub Issues:

@github-actions
Copy link
Contributor

github-actions bot commented Nov 2, 2021

Hello. You may have forgotten to update the changelog!
Please edit .github/CHANGELOG.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@Jaybsoni Jaybsoni requested a review from antalszava November 2, 2021 21:37
@codecov
Copy link

codecov bot commented Nov 2, 2021

Codecov Report

Merging #160 (00a316e) into master (1ac6b8b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #160   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          182       182           
=========================================
  Hits           182       182           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ac6b8b...00a316e. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 2, 2021

Test Report (C++) on Ubuntu

       1 files  ±0         1 suites  ±0   0s ⏱️ ±0s
   327 tests ±0     327 ✔️ ±0  0 💤 ±0  0 ±0 
1 185 runs  ±0  1 185 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 00a316e. ± Comparison against base commit 1ac6b8b.

♻️ This comment has been updated with latest results.

@Jaybsoni Jaybsoni mentioned this pull request Nov 2, 2021
@Jaybsoni Jaybsoni mentioned this pull request Nov 2, 2021
To be consistent with other plugins and not cause errors for the auto version bumping
@Jaybsoni Jaybsoni requested a review from mlxd November 3, 2021 14:56
Copy link
Contributor

@antalszava antalszava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 💪 🙂

@@ -36,4 +36,4 @@ jobs:
body: updated changelog and _version.py
branch: post-release-version-bump
reviewers: antalszava
base: main
base: master
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is something we can change soon when time permits.

Copy link
Member

@mlxd mlxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good -- merge away!

@antalszava antalszava merged commit 4a8a798 into master Nov 3, 2021
@antalszava antalszava deleted the version_bump_error branch November 3, 2021 15:47
antalszava added a commit that referenced this pull request Nov 3, 2021
* Added auto version bump functionality to pl lightning (#159)

* Added auto version bump functionality to pl lightning

* Update .github/workflows/pre_release_version_bump.yml

removed trailing white space

* Update .github/workflows/post_release_version_bump.yml

Co-authored-by: Jay Soni <[email protected]>

* Update .github/workflows/pre_release_version_bump.yml

Co-authored-by: Jay Soni <[email protected]>

* removed flag for pennylane release as it is not required

Co-authored-by: antalszava <[email protected]>

* Update pre_release_version_bump.yml (#160)

* Update pre_release_version_bump.yml

* Update pre_release_version_bump.yml

* Update pre_release_version_bump.yml

* Update .github/workflows/pre_release_version_bump.yml

* Apply suggestions from code review

* Update post_release_version_bump.yml

swap main --> master

* Update CHANGELOG.md

To be consistent with other plugins and not cause errors for the auto version bumping

* pre release version bump

* updates

* Update pennylane_lightning/_version.py

* formatting updates to changelog

Co-authored-by: Jay Soni <[email protected]>
Co-authored-by: antalszava <[email protected]>
Co-authored-by: antalszava <[email protected]>
mlxd added a commit that referenced this pull request Nov 15, 2021
* Version Bump `0.19.0` (#163)

* Added auto version bump functionality to pl lightning (#159)

* Added auto version bump functionality to pl lightning

* Update .github/workflows/pre_release_version_bump.yml

removed trailing white space

* Update .github/workflows/post_release_version_bump.yml

Co-authored-by: Jay Soni <[email protected]>

* Update .github/workflows/pre_release_version_bump.yml

Co-authored-by: Jay Soni <[email protected]>

* removed flag for pennylane release as it is not required

Co-authored-by: antalszava <[email protected]>

* Update pre_release_version_bump.yml (#160)

* Update pre_release_version_bump.yml

* Update pre_release_version_bump.yml

* Update pre_release_version_bump.yml

* Update .github/workflows/pre_release_version_bump.yml

* Apply suggestions from code review

* Update post_release_version_bump.yml

swap main --> master

* Update CHANGELOG.md

To be consistent with other plugins and not cause errors for the auto version bumping

* pre release version bump

* updates

* Update pennylane_lightning/_version.py

* formatting updates to changelog

Co-authored-by: Jay Soni <[email protected]>
Co-authored-by: antalszava <[email protected]>
Co-authored-by: antalszava <[email protected]>

* Fix OpenMP library issues on M1 Macs (#166)

* Fix OMP issue on M1 macs

* Update changelog

* Fix CI builder release issues (#168)

* Fix OMP issue on M1 macs

* Update changelog

* Fix CI builder

* Trigger CI on release creation

* CI wheelbuilder updates (#169)

* Fix OMP with ARM MacOS

* Ensure wheels uploaded to GH

* Separate out noarch wheels

* Update .github/CHANGELOG.md

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Jay Soni <[email protected]>
Co-authored-by: antalszava <[email protected]>
Co-authored-by: antalszava <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants