-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pre_release_version_bump.yml #160
Conversation
Hello. You may have forgotten to update the changelog!
|
Codecov Report
@@ Coverage Diff @@
## master #160 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 4
Lines 182 182
=========================================
Hits 182 182 Continue to review full report at Codecov.
|
swap main --> master
To be consistent with other plugins and not cause errors for the auto version bumping
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 💪 🙂
@@ -36,4 +36,4 @@ jobs: | |||
body: updated changelog and _version.py | |||
branch: post-release-version-bump | |||
reviewers: antalszava | |||
base: main | |||
base: master |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is something we can change soon when time permits.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good -- merge away!
* Added auto version bump functionality to pl lightning (#159) * Added auto version bump functionality to pl lightning * Update .github/workflows/pre_release_version_bump.yml removed trailing white space * Update .github/workflows/post_release_version_bump.yml Co-authored-by: Jay Soni <[email protected]> * Update .github/workflows/pre_release_version_bump.yml Co-authored-by: Jay Soni <[email protected]> * removed flag for pennylane release as it is not required Co-authored-by: antalszava <[email protected]> * Update pre_release_version_bump.yml (#160) * Update pre_release_version_bump.yml * Update pre_release_version_bump.yml * Update pre_release_version_bump.yml * Update .github/workflows/pre_release_version_bump.yml * Apply suggestions from code review * Update post_release_version_bump.yml swap main --> master * Update CHANGELOG.md To be consistent with other plugins and not cause errors for the auto version bumping * pre release version bump * updates * Update pennylane_lightning/_version.py * formatting updates to changelog Co-authored-by: Jay Soni <[email protected]> Co-authored-by: antalszava <[email protected]> Co-authored-by: antalszava <[email protected]>
* Version Bump `0.19.0` (#163) * Added auto version bump functionality to pl lightning (#159) * Added auto version bump functionality to pl lightning * Update .github/workflows/pre_release_version_bump.yml removed trailing white space * Update .github/workflows/post_release_version_bump.yml Co-authored-by: Jay Soni <[email protected]> * Update .github/workflows/pre_release_version_bump.yml Co-authored-by: Jay Soni <[email protected]> * removed flag for pennylane release as it is not required Co-authored-by: antalszava <[email protected]> * Update pre_release_version_bump.yml (#160) * Update pre_release_version_bump.yml * Update pre_release_version_bump.yml * Update pre_release_version_bump.yml * Update .github/workflows/pre_release_version_bump.yml * Apply suggestions from code review * Update post_release_version_bump.yml swap main --> master * Update CHANGELOG.md To be consistent with other plugins and not cause errors for the auto version bumping * pre release version bump * updates * Update pennylane_lightning/_version.py * formatting updates to changelog Co-authored-by: Jay Soni <[email protected]> Co-authored-by: antalszava <[email protected]> Co-authored-by: antalszava <[email protected]> * Fix OpenMP library issues on M1 Macs (#166) * Fix OMP issue on M1 macs * Update changelog * Fix CI builder release issues (#168) * Fix OMP issue on M1 macs * Update changelog * Fix CI builder * Trigger CI on release creation * CI wheelbuilder updates (#169) * Fix OMP with ARM MacOS * Ensure wheels uploaded to GH * Separate out noarch wheels * Update .github/CHANGELOG.md Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Jay Soni <[email protected]> Co-authored-by: antalszava <[email protected]> Co-authored-by: antalszava <[email protected]>
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
tests
directory!All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs
.Ensure that the test suite passes, by running
make test
.Add a new entry to the
.github/CHANGELOG.md
file, summarizing thechange, and including a link back to the PR.
Ensure that code is properly formatted by running
make format
.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context:
Description of the Change:
Benefits:
Possible Drawbacks:
Related GitHub Issues: