Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change PPC wheel builder image to have C++17 compatible compiler #120

Merged
merged 4 commits into from
Jul 29, 2021

Conversation

mlxd
Copy link
Member

@mlxd mlxd commented Jul 29, 2021

Context: The current wheel-builder image uses an older compiler toolkit without full-featured C++17 support. This PR updates the wheelbuilder image to use a modern compiler toolkit.

Description of the Change: Change the wheel-builder image for ppc64le wheels.

Benefits: Allow compilation of ppc64le wheel

Possible Drawbacks: None

Related GitHub Issues: #119

@github-actions
Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit .github/CHANGELOG.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@codecov
Copy link

codecov bot commented Jul 29, 2021

Codecov Report

Merging #120 (18498c6) into master (a1bb111) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #120   +/-   ##
=======================================
  Coverage   98.14%   98.14%           
=======================================
  Files           3        3           
  Lines          54       54           
=======================================
  Hits           53       53           
  Misses          1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1bb111...18498c6. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 29, 2021

Test Report (C++) on Ubuntu

    1 files  ±0      1 suites  ±0   0s ⏱️ ±0s
118 tests ±0  118 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
370 runs  ±0  370 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 2b26841. ± Comparison against base commit 2b26841.

♻️ This comment has been updated with latest results.

@mlxd mlxd requested a review from trbromley July 29, 2021 10:45
Copy link
Contributor

@trbromley trbromley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎸

Co-authored-by: Tom Bromley <[email protected]>
@mlxd mlxd merged commit 2b26841 into master Jul 29, 2021
@mlxd mlxd deleted the fix_ppc_builder branch July 29, 2021 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants