Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jQuery version #118

Merged
merged 7 commits into from
Jul 29, 2021
Merged

Update jQuery version #118

merged 7 commits into from
Jul 29, 2021

Conversation

mlxd
Copy link
Member

@mlxd mlxd commented Jul 26, 2021

Context: Recently, Dependabot issued an alert for docs/xanadu_theme/static/jquery.js and recommended an upgrade to a minimum jQuery version of 3.5.0. This PR addresses the security vulnerability and updates the instructions for building the Sphinx documentation.

Description of the Change:

  • The static copies of jQuery and Bootstrap in the CSS theme have been removed (these are pulled from a CDN instead).

Benefits: Fixes dependabot security alert

Possible Drawbacks: None

Related GitHub Issues: None. [ch7715]

@codecov
Copy link

codecov bot commented Jul 26, 2021

Codecov Report

Merging #118 (b2c9941) into master (bdf8aa8) will not change coverage.
The diff coverage is n/a.

❗ Current head b2c9941 differs from pull request most recent head 4754d60. Consider uploading reports for the commit 4754d60 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #118   +/-   ##
=======================================
  Coverage   98.14%   98.14%           
=======================================
  Files           3        3           
  Lines          54       54           
=======================================
  Hits           53       53           
  Misses          1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdf8aa8...4754d60. Read the comment docs.

@mlxd mlxd requested a review from trbromley July 26, 2021 11:22
Copy link
Contributor

@trbromley trbromley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mlxd!

@josh146
Copy link
Member

josh146 commented Jul 27, 2021

image

Flyby comment purely to say that these are my favourite types of PRs 🙌

mlxd and others added 3 commits July 27, 2021 08:56
@mlxd mlxd requested a review from trbromley July 28, 2021 09:51
@co9olguy
Copy link
Member

We should really backport this fix to any other repos that have the same legacy theme

@josh146
Copy link
Member

josh146 commented Jul 28, 2021

We should really backport this fix to any other repos that have the same legacy theme

Definitely time to move the theme to a central repository :(

@github-actions
Copy link
Contributor

github-actions bot commented Jul 29, 2021

Test Report (C++) on Ubuntu

    1 files  ±0      1 suites  ±0   0s ⏱️ ±0s
118 tests ±0  118 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
370 runs  ±0  370 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit a1bb111. ± Comparison against base commit a1bb111.

♻️ This comment has been updated with latest results.

@mlxd mlxd merged commit a1bb111 into master Jul 29, 2021
@mlxd mlxd deleted the 7715_theme_update branch July 29, 2021 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants