Implement PSWAP in Lightning-Kokkos #1089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-lightning into feature/pswap-impl
…-lightning into feature/pswap-impl
…-lightning into feature/pswap-impl
…-lightning into feature/pswap-impl
jzaia18
added
the
draft
jzaia18
changed the base branch from
feature/pswap-impl-base
to
feature/pswap-impl
jzaia18
changed the base branch from
feature/pswap-impl
to
feature/pswap-impl-base
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/pswap-impl-base #1089 +/- ##
==========================================================
Coverage ? 95.46%
==========================================================
Files ? 177
Lines ? 27734
Branches ? 0
==========================================================
Hits ? 26477
Misses ? 1257
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…nnylane-lightning into feature/pswap-impl-kokkos
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a native PSWAP gate implementation in Lightning-Kokkos to improve performance while updating related configurations and test cases.
- Update changelog entries for both Lightning-Kokkos and Lightning-Qubit.
- Remove the PSWAP entry from lightning_qubit.py and add its configuration in TOML files for both backends.
- Update test cases to incorporate the new PSWAP gate.
Reviewed Changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| .github/CHANGELOG.md | Added changelog entries for PSWAP in Lightning-Kokkos and Lightning-Qubit. |
| pennylane_lightning/lightning_qubit/lightning_qubit.py | Removed PSWAP operator mapping for Lightning-Qubit. |
| pennylane_lightning/lightning_kokkos/lightning_kokkos.toml | Added PSWAP gate configuration under Lightning-Kokkos. |
| pennylane_lightning/lightning_qubit/lightning_qubit.toml | Added PSWAP gate configuration for Lightning-Qubit. |
| tests/test_gates.py | Updated unit tests to include PSWAP gate verification. |
Comments suppressed due to low confidence (1)
pennylane_lightning/lightning_qubit/lightning_qubit.py:70
- PSWAP has been removed from the Lightning-Qubit implementation. Confirm that this removal aligns with the intended design given the corresponding changelog entry.
"PSWAP": OperatorProperties(),
AmintorDusko
approved these changes
Mar 14, 2025
LuisAlfredoNu
approved these changes
Mar 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
PSWAP does not have a custom implementation within Lightning-Kokkos. This results in it using the implementation from PennyLane-Core whenever the gate is used. By implementing the gate directly in Lightning-Kokkos, performance of the PSWAP gate can be improved.
Description of the Change:
Implements the PSWAP gate natively in Lightning-Kokkos.
Benefits:
Possible Drawbacks:
Related GitHub Issues:
[sc-85797]