Fix unit test for applyControlledPhaseShift #1083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jzaia18
added
the
draft
|
Hello. You may have forgotten to update the changelog!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1083 +/- ##
==========================================
- Coverage 97.94% 94.60% -3.34%
==========================================
Files 233 177 -56
Lines 40370 27606 -12764
==========================================
- Hits 39539 26118 -13421
- Misses 831 1488 +657 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…nnylane-lightning into fix/fix-missing-unit-test
jzaia18
changed the title
There was a problem hiding this comment.
PR Overview
This PR fixes the issue where only one unit test was executed in testApplyControlledPhaseShift.
- Updated the changelog to document the bug fix.
- Incremented the version number from "0.41.0-dev30" to "0.41.0-dev31" to include the fix.
Reviewed Changes
| File | Description |
|---|---|
| .github/CHANGELOG.md | Added changelog entry for the fix of skipped unit tests. |
| pennylane_lightning/core/_version.py | Incremented the version to reflect the new bug fix. |
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
jzaia18
added
bug-fix
josephleekl
reviewed
Mar 10, 2025
...lightning/core/src/simulators/lightning_qubit/gates/tests/Test_GateImplementations_Param.cpp
Outdated
Show resolved
Hide resolved
josephleekl
reviewed
Mar 10, 2025
There was a problem hiding this comment.
Great find @jzaia18 ! Just a small comment, happy to approve once updated! (and tests all pass)
josephleekl
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
The unit test
testApplyControlledPhaseShiftinpennylane_lightning/core/src/simulators/lightning_qubit/gates/tests/Test_GateImplementations_Param.cppsets up 2 unit tests but only actually executes 1 of them.Description of the Change:
Fix
testApplyControlledPhaseShiftto run all unit tests that it constructs.Benefits:
Possible Drawbacks:
Related GitHub Issues: