Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup after ARM GPU runner #1074

Merged
merged 4 commits into from
Mar 3, 2025

Conversation

josephleekl
Copy link
Contributor

@josephleekl josephleekl commented Feb 28, 2025

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    tests directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the .github/CHANGELOG.md file, summarizing the
    change, and including a link back to the PR.

  • Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context:
Currently Arm GPU CI runners may be reused between runs, and there is no cleanup job after each runs. This means that caches/wheels from previous runs contaminate later runs.

Description of the Change:
Clean cache after each Arm GPU CI runs. E.g. here

Benefits:
No contamination between runs.

Possible Drawbacks:

Related GitHub Issues:
[sc-85613]

@josephleekl josephleekl added the ci:build_wheels Activate wheel building. label Feb 28, 2025
Copy link

codecov bot commented Feb 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.18%. Comparing base (ec9b8f9) to head (1a04de5).
Report is 3 commits behind head on increase-aarch-wheel-time.

Additional details and impacted files
@@                    Coverage Diff                     @@
##           increase-aarch-wheel-time    #1074   +/-   ##
==========================================================
  Coverage                      55.18%   55.18%           
==========================================================
  Files                             28       28           
  Lines                           2631     2631           
==========================================================
  Hits                            1452     1452           
  Misses                          1179     1179           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@josephleekl
Copy link
Contributor Author

The failures here for ARM CUDA LTensor are fixed in the other PR - I didn't want to combine the two since that one was already approved, so I don't want to contaminate that

@josephleekl josephleekl marked this pull request as ready for review February 28, 2025 19:33
@AmintorDusko
Copy link
Contributor

The failures here for ARM CUDA LTensor are fixed in the other PR - I didn't want to combine the two since that one was already approved, so I don't want to contaminate that

In this case, please change the aimed branch to the other PR branch. This way we can see the combined effect.

@josephleekl josephleekl changed the base branch from master to increase-aarch-wheel-time March 3, 2025 15:37
@josephleekl
Copy link
Contributor Author

The failures here for ARM CUDA LTensor are fixed in the other PR - I didn't want to combine the two since that one was already approved, so I don't want to contaminate that

In this case, please change the aimed branch to the other PR branch. This way we can see the combined effect.

updated! I'll wait for the tests to run and see the result

Copy link
Member

@maliasadi maliasadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

Copy link
Contributor

@AmintorDusko AmintorDusko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! Thank you!

@josephleekl josephleekl merged commit f13ecda into increase-aarch-wheel-time Mar 3, 2025
78 checks passed
@josephleekl josephleekl deleted the cleanup-armgpu-runner branch March 3, 2025 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:build_wheels Activate wheel building.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants