-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Capture] lightning.qubit
can execute circuits transformed by qml.defer_measurements
, add support for ctrl
and adjoint
#1069
Conversation
Hello. You may have forgotten to update the changelog!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1069 +/- ##
===========================================
- Coverage 97.98% 64.44% -33.55%
===========================================
Files 233 28 -205
Lines 40090 2652 -37438
===========================================
- Hits 39284 1709 -37575
- Misses 806 943 +137 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@astralcai PennyLaneAI/pennylane#6961 makes breaking changes to the |
…htning into defer_measurement
lightning.qubit
can execute circuits transformed by qml.defer_measurements
in analytic modelightning.qubit
can execute circuits transformed by qml.defer_measurements
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, just one test suggestion. Otherwise ready to approve.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @astralcai! No blocker from my side, just a few questions before approving the PR 🙂
lightning.qubit
can execute circuits transformed by qml.defer_measurements
lightning.qubit
can execute circuits transformed by qml.defer_measurements
, add support for ctrl
and adjoint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @astralcai! Feel free to merge the PR 🎉
Context:
This PR follows up on PennyLaneAI/pennylane#6838 to add support to execute circuits transformed with
defer_measurements
onlightning.qubit
.This PR mirrors the same implementation as for
default.qubit
: PennyLaneAI/pennylane#6937Description of the Change:
Update
LightningInterpreter
to supportctrl_transform
andadjoint_transform
primitives usingCollectOpsandMeas
.Related Shortcut Story:
[sc-82056] [sc-82065]