-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance Sparse Observable Handling and Expand State Initialization #1068
Conversation
Hello. You may have forgotten to update the changelog!
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1068 +/- ##
==========================================
+ Coverage 97.98% 98.94% +0.95%
==========================================
Files 233 266 +33
Lines 40090 44752 +4662
==========================================
+ Hits 39284 44281 +4997
+ Misses 806 471 -335 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…/PennyLaneAI/pennylane-lightning into implement/Lightning_Sparse_Gates
…neAI/pennylane-lightning into implement/Lightning_Sparse_Gates
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot! I don't have any blocking suggestions. Just one last question on the scope: from several changes to docstr, it looks like we dropped the wording for batched state. Is it because in the past we didn't actually support the batched states in these interface, or there's plan to move it around somewhere else?
Co-authored-by: Yushao Chen (Jerry) <[email protected]>
@JerryChen97, I don't have a good answer for you. Perhaps @maliasadi can clarify this subject. |
…neAI/pennylane-lightning into implement/Lightning_Sparse_Gates
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @AmintorDusko! 🎆 Happy to approve, just a non-blocking comment. Also just want to make sure the GPU coverage is OK once all the tests complete
Co-authored-by: Joseph Lee <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @AmintorDusko . Nice work. Would you mind to trigger the mpi tests as changes are made to the mpi part? Happy to approve once all CIs turn green.
Thank you very much! |
…/PennyLaneAI/pennylane-lightning into implement/Lightning_Sparse_Gates
Enhance Sparse Observable Handling and Expand State Initialization
Summary:
This PR expands the capabilities of our sparse observable handling and add support for state vector initialization with sparse data. Key changes include:
expval
,var
, and measures with samples Support: Modified theexpval
,var
, and measures with samples to accept generalSparseHermitianObs
objects, allowing for extending the calculation of expectation values, variances, and measures with samples to other sparse observables.Detailed Changes:
expval
,var
, and measures with samples:SparseHermitianObs
objects as arguments.Related issues
[sc-86157] [sc-85831]