Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update qemu to fix aarch64 wheel action #1056

Merged
merged 5 commits into from
Jan 29, 2025
Merged

Update qemu to fix aarch64 wheel action #1056

merged 5 commits into from
Jan 29, 2025

Conversation

josephleekl
Copy link
Contributor

@josephleekl josephleekl commented Jan 28, 2025

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    tests directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the .github/CHANGELOG.md file, summarizing the
    change, and including a link back to the PR.

  • Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context:
The aarch64 wheel build CI action has been failing since circa 24 Jan 2025. They fail with a segmentation fault during the CIBW process. This has also been observed for similar wheel builds with QEMU with other repositories:
docker/setup-qemu-action#188
ssciwr/clang-format-wheel#124
tonistiigi/binfmt#215
tonistiigi/binfmt#165
and fix attempt:
ssciwr/clang-format-wheel#125

It is due to using an old version (v7) of qemu that comes with binfmt. setup-qemu-action by default uses binfmt:latest image which has not been updated in 2 years.

Description of the Change:
Use a newer QEMU image (v8) from binfmt.

Benefits:
aarch64 wheel builds will succeed again, e.g.
Possible Drawbacks:

Related GitHub Issues:

[sc-83297]

@josephleekl josephleekl added the ci:build_wheels Activate wheel building. label Jan 28, 2025
Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit .github/CHANGELOG.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@josephleekl josephleekl marked this pull request as ready for review January 28, 2025 21:18
Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.77%. Comparing base (5f6c420) to head (5145dfe).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (5f6c420) and HEAD (5145dfe). Click for more details.

HEAD has 30 uploads less than BASE
Flag BASE (5f6c420) HEAD (5145dfe)
35 5
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1056       +/-   ##
===========================================
- Coverage   97.63%   27.77%   -69.86%     
===========================================
  Files         233       29      -204     
  Lines       39598     2607    -36991     
===========================================
- Hits        38660      724    -37936     
- Misses        938     1883      +945     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@maliasadi maliasadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

Copy link
Member

@multiphaseCFD multiphaseCFD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @josephleekl . Nice one

@josephleekl josephleekl merged commit 63b9ecd into master Jan 29, 2025
76 of 78 checks passed
@josephleekl josephleekl deleted the qemu-action branch January 29, 2025 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:build_wheels Activate wheel building.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants