-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update qemu to fix aarch64 wheel action #1056
Conversation
Hello. You may have forgotten to update the changelog!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1056 +/- ##
===========================================
- Coverage 97.63% 27.77% -69.86%
===========================================
Files 233 29 -204
Lines 39598 2607 -36991
===========================================
- Hits 38660 724 -37936
- Misses 938 1883 +945 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌
Co-authored-by: Ali Asadi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @josephleekl . Nice one
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
tests
directory!All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs
.Ensure that the test suite passes, by running
make test
.Add a new entry to the
.github/CHANGELOG.md
file, summarizing thechange, and including a link back to the PR.
Ensure that code is properly formatted by running
make format
.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context:
The aarch64 wheel build CI action has been failing since circa 24 Jan 2025. They fail with a segmentation fault during the CIBW process. This has also been observed for similar wheel builds with QEMU with other repositories:
docker/setup-qemu-action#188
ssciwr/clang-format-wheel#124
tonistiigi/binfmt#215
tonistiigi/binfmt#165
and fix attempt:
ssciwr/clang-format-wheel#125
It is due to using an old version (v7) of qemu that comes with binfmt.
setup-qemu-action
by default usesbinfmt:latest
image which has not been updated in 2 years.Description of the Change:
Use a newer QEMU image (v8) from binfmt.
Benefits:
aarch64 wheel builds will succeed again, e.g.
Possible Drawbacks:
Related GitHub Issues:
[sc-83297]