-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix lightning interpreter with for, while, and cond #1051
Conversation
Hello. You may have forgotten to update the changelog!
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1051 +/- ##
===========================================
- Coverage 94.27% 33.25% -61.02%
===========================================
Files 233 29 -204
Lines 39067 2607 -36460
===========================================
- Hits 36830 867 -35963
+ Misses 2237 1740 -497 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @albi3ro! Could you also add a line in the changelog?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Context:
In PL PR #6786, I added additional kwargs for the for, while, and cond primitives for handling inputs with abstract shapes. Those inputs broken the custom registrations for the lightning interpreter.
Description of the Change:
Import the
FlattenedHigherOrderPrimitives
to get default behavior for for, while, and cond. These should better stay updated with changes to the primitives and the base class.Benefits:
Lightning works again.
Possible Drawbacks:
Related GitHub Issues: